diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-28 11:11:36 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-28 11:11:36 +0000 |
| commit | c3b4463c325d5a7f512130c02a68913cc52d20fe (patch) | |
| tree | 85f1351da9c53db857c0522f2255a7f94786578d /chrome_frame/test | |
| parent | 2249aeb30e1d9c48d7c01ad9d568cab12ceeda70 (diff) | |
| download | chromium_src-c3b4463c325d5a7f512130c02a68913cc52d20fe.zip chromium_src-c3b4463c325d5a7f512130c02a68913cc52d20fe.tar.gz chromium_src-c3b4463c325d5a7f512130c02a68913cc52d20fe.tar.bz2 | |
With the change in the constructor for the ChromeThread class, we are seeing a DCHECK fire in
the Chrome frame network tests for whether the current thread is the UI thread. We need to invoke
the correct constructor.
The other fix is in our com_util::IDispatchImpl class where we end up crashing if we fail to find
the type information for the passed in interface. Strangely this is failing for the IChromeFrame
interface which is an IDispatch derivative and seems to be correctly registered. It also fails
with the ATL IDispatchImpl classes though. However we should not crash here :) I also removed
the NOTREACHED as it keeps firing on debug test runs. Will take a look at this closely later.
TBR=tommi
Review URL: http://codereview.chromium.org/343013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30333 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/test')
| -rw-r--r-- | chrome_frame/test/net/fake_external_tab.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome_frame/test/net/fake_external_tab.cc b/chrome_frame/test/net/fake_external_tab.cc index 78430fe..9ada450 100644 --- a/chrome_frame/test/net/fake_external_tab.cc +++ b/chrome_frame/test/net/fake_external_tab.cc @@ -146,7 +146,8 @@ CFUrlRequestUnittestRunner::CFUrlRequestUnittestRunner(int argc, char** argv) EXPECT_TRUE(pss_subclass_->Subclass(fake_chrome_.user_data())); StartChromeFrameInHostBrowser(); // Register the main thread by instantiating it, but don't call any methods. - main_thread_.reset(new ChromeThread(ChromeThread::UI)); + main_thread_.reset(new ChromeThread(ChromeThread::UI, + MessageLoop::current())); DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI)); } |