diff options
| author | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-18 22:18:39 +0000 |
|---|---|---|
| committer | tommi@chromium.org <tommi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-18 22:18:39 +0000 |
| commit | 908f687c4eed587612c2d179dcc58c54ee1d2cbf (patch) | |
| tree | 29269728916ba07cfcd82f711ef9513fe7dc4910 /chrome_frame/test | |
| parent | 9bf414752683e232429b8d18022bfc43c80cc279 (diff) | |
| download | chromium_src-908f687c4eed587612c2d179dcc58c54ee1d2cbf.zip chromium_src-908f687c4eed587612c2d179dcc58c54ee1d2cbf.tar.gz chromium_src-908f687c4eed587612c2d179dcc58c54ee1d2cbf.tar.bz2 | |
Fix for referrer flakyness. There were two problems:
Grabbing the referrer header when the request is made and not in BeforeNavigate2.
The request headers aren't always available in BeforeNavigate2. Mshtml provides these
headers in IHttpNegotiate::BeginningTransaction, which is where we now grab them.
There was a race in chrome_frame_automation.cc where we use std::string to store the referrer url and then access that string from different threads. This was causing the referrer URL to be missing at some times and at other times be sent over to chrome as bad string (e.g. containing embedded nulls) and subsequently be deemed an invalid URL and dropped.
TEST=Fixes referrer header flakyness.
BUG=34812
Review URL: http://codereview.chromium.org/646013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39383 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame/test')
| -rw-r--r-- | chrome_frame/test/test_with_web_server.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/chrome_frame/test/test_with_web_server.cc b/chrome_frame/test/test_with_web_server.cc index 56acce1..fbd21d3 100644 --- a/chrome_frame/test/test_with_web_server.cc +++ b/chrome_frame/test/test_with_web_server.cc @@ -683,9 +683,8 @@ TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_NavigateOut) { } const wchar_t kReferrerMainTest[] = L"files/referrer_main.html"; -// Marking this as FLAKY as this has been failing randomly on the builder. -// http://code.google.com/p/chromium/issues/detail?id=34812 -TEST_F(ChromeFrameTestWithWebServer, FLAKY_FullTabModeIE_ReferrerTest) { + +TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_ReferrerTest) { SimpleBrowserTest(IE, kReferrerMainTest, L"FullTab_ReferrerTest"); } |