summaryrefslogtreecommitdiffstats
path: root/chrome_frame
diff options
context:
space:
mode:
authorananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-14 00:24:47 +0000
committerananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-14 00:24:47 +0000
commitf7ff4d768a08322df5629130c6407efad20e9b04 (patch)
tree057447c0c72908abb0868fda06e805e24336105b /chrome_frame
parent97e856b1ee60c7573406368b32acfa7a32010e59 (diff)
downloadchromium_src-f7ff4d768a08322df5629130c6407efad20e9b04.zip
chromium_src-f7ff4d768a08322df5629130c6407efad20e9b04.tar.gz
chromium_src-f7ff4d768a08322df5629130c6407efad20e9b04.tar.bz2
Enable ChromeFrame net tests for IE versions 8 and below. Changes include the following:-
1. Get rid of the dummy AtlModule registration in the net test suite. This is no longer needed as there is a module instance instantiated by the content code. 2. The test suite class now instantiates the ShadowAtExitManager class which allows nesting of AtExitManager instances. This is needed because the ChromeFrame net tests suite now calls into ContentMain which also instantiates an AtExitManager instance. Fixes bug http://code.google.com/p/chromium/issues/detail?id=105435 BUG=105435 TEST=ChromeFrame net tests should now run on the builders. Review URL: http://codereview.chromium.org/8898026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114320 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome_frame')
-rw-r--r--chrome_frame/test/net/fake_external_tab.cc26
1 files changed, 7 insertions, 19 deletions
diff --git a/chrome_frame/test/net/fake_external_tab.cc b/chrome_frame/test/net/fake_external_tab.cc
index 34a728a..0dd79f3 100644
--- a/chrome_frame/test/net/fake_external_tab.cc
+++ b/chrome_frame/test/net/fake_external_tab.cc
@@ -263,6 +263,11 @@ void FilterDisabledTests() {
// Flaky on the tryservers, http://crbug.com/103097
"URLRequestTestHTTP.MultipleRedirectTest",
"URLRequestTestHTTP.NetworkDelegateRedirectRequest",
+
+ // Newly added tests which fail in CF.
+ "HTTPSRequestTest.HTTPSPreloadedHSTSTest",
+ "HTTPSRequestTest.ResumeTest",
+ "HTTPSRequestTest.SSLSessionCacheShardTest",
};
const char* ie9_disabled_tests[] = {
@@ -659,21 +664,6 @@ void CFUrlRequestUnittestRunner::PostDestroyThreads() {
#endif
}
-// We need a module since some of the accessibility code that gets pulled
-// in here uses ATL.
-class ObligatoryModule: public CAtlExeModuleT<ObligatoryModule> {
- public:
- static HRESULT InitializeCom() {
- return OleInitialize(NULL);
- }
-
- static void UninitializeCom() {
- OleUninitialize();
- }
-};
-
-ObligatoryModule g_obligatory_atl_module;
-
const char* IEVersionToString(IEVersion version) {
switch (version) {
case IE_6:
@@ -729,15 +719,13 @@ int main(int argc, char** argv) {
g_argc = argc;
g_argv = argv;
- // Temporarily disabled, http://crbug.com/105435.
- if (true || chrome_frame_test::GetInstalledIEVersion() >= IE_9) {
+ if (chrome_frame_test::GetInstalledIEVersion() >= IE_9) {
// Adding this here as the command line and the logging stuff gets
// initialized in the NetTestSuite constructor. Did not want to break that.
base::AtExitManager at_exit_manager;
CommandLine::Init(argc, argv);
CFUrlRequestUnittestRunner::InitializeLogging();
- LOG(INFO) << "Temporarily not running ChromeFrame net tests.";
- //LOG(INFO) << "Not running ChromeFrame net tests on IE9+";
+ LOG(INFO) << "Not running ChromeFrame net tests on IE9+";
return 0;
}