diff options
author | servolk <servolk@chromium.org> | 2015-12-09 09:08:43 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-12-09 17:09:45 +0000 |
commit | 62b283acf539a42e6b698d000653675b0d796572 (patch) | |
tree | 70238bdfc7fec400b35ce158ebe409688e514950 /chromecast | |
parent | 86a02ce7dcfc4bcdce94bbf393c72ef4be15b54d (diff) | |
download | chromium_src-62b283acf539a42e6b698d000653675b0d796572.zip chromium_src-62b283acf539a42e6b698d000653675b0d796572.tar.gz chromium_src-62b283acf539a42e6b698d000653675b0d796572.tar.bz2 |
[Chromecast] Suppress error logging for cancelled URL requests
This should avoid having net::ERR_ABORTED logs for each direct URL
playback that we currently have in our log files.
The problem was that direct URL playback code path creates and then
cancels URLRequest, and currently we log an error for each URLRequest
that didn't succeeded. We should adjust our logic slightly and do what
net::URLRequest::~URLRequest does:
// Log error only on failure, not cancellation, as even successful
// requests are "cancelled" on destruction.
if (status_.status() == URLRequestStatus::FAILED)
net_error = status_.error();
BUG=567962
Review URL: https://codereview.chromium.org/1509273004
Cr-Commit-Position: refs/heads/master@{#364090}
Diffstat (limited to 'chromecast')
-rw-r--r-- | chromecast/browser/cast_resource_dispatcher_host_delegate.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chromecast/browser/cast_resource_dispatcher_host_delegate.cc b/chromecast/browser/cast_resource_dispatcher_host_delegate.cc index 9a935fb..ff9faa2 100644 --- a/chromecast/browser/cast_resource_dispatcher_host_delegate.cc +++ b/chromecast/browser/cast_resource_dispatcher_host_delegate.cc @@ -8,13 +8,14 @@ #include "chromecast/net/connectivity_checker.h" #include "net/base/net_errors.h" #include "net/url_request/url_request.h" +#include "net/url_request/url_request_status.h" namespace chromecast { namespace shell { void CastResourceDispatcherHostDelegate::RequestComplete( net::URLRequest* url_request) { - if (!url_request->status().is_success()) { + if (url_request->status().status() == net::URLRequestStatus::FAILED) { LOG(ERROR) << "Failed to load resource " << url_request->url() << "; status:" << url_request->status().status() << ", error:" << net::ErrorToShortString(url_request->status().error()); |