diff options
author | dhsharp <dhsharp@chromium.org> | 2015-09-08 12:06:48 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-09-08 19:07:28 +0000 |
commit | 2d8385a144c801b96b9338f89b1eb8fa8cbf5f6d (patch) | |
tree | fdf470379e6fad2d8d2e05fc8418b4454062577c /chromeos/dbus/debug_daemon_client.h | |
parent | dfffbacbdd7196c880f7effb4a489e004c9a6dea (diff) | |
download | chromium_src-2d8385a144c801b96b9338f89b1eb8fa8cbf5f6d.zip chromium_src-2d8385a144c801b96b9338f89b1eb8fa8cbf5f6d.tar.gz chromium_src-2d8385a144c801b96b9338f89b1eb8fa8cbf5f6d.tar.bz2 |
dbus/debugd: Add method for org.chromium.debugd.GetPerfOutput
This method will replace org.chromium.debug.GetRandomPerfOutput.
Unfortunately, the C++ method name "GetPerfOutput" was used for
the DBus method name "GetRandomPerfOutput", which means the most
appropriate name is taken. Since the DBus method "GetPerfOutput" will
soon be removed, I've overloaded the C++ method "GetPerfOutput" to call the
DBus method "GetPerfOutput". The difference betweeen these two methods
is that the new one takes a vector<string> containing the perf arguments
to call, whereas the old one makes a random selection of perf arguments.
The two methods have the same output type, and so share the
OnGetPerfOutput callback, and the GetPerfOutputCallback type.
Review URL: https://codereview.chromium.org/1332453002
Cr-Commit-Position: refs/heads/master@{#347759}
Diffstat (limited to 'chromeos/dbus/debug_daemon_client.h')
-rw-r--r-- | chromeos/dbus/debug_daemon_client.h | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chromeos/dbus/debug_daemon_client.h b/chromeos/dbus/debug_daemon_client.h index b91d2c1..0950e90 100644 --- a/chromeos/dbus/debug_daemon_client.h +++ b/chromeos/dbus/debug_daemon_client.h @@ -95,9 +95,15 @@ class CHROMEOS_EXPORT DebugDaemonClient : public DBusClient { const std::vector<uint8>& perf_stat)>; // Runs perf for |duration| seconds and returns data collected. + // TODO(dhsharp): Remove this overload. virtual void GetPerfOutput(uint32_t duration, const GetPerfOutputCallback& callback) = 0; + // Runs perf with arguments for |duration| seconds and returns data collected. + virtual void GetPerfOutput(uint32_t duration, + const std::vector<std::string>& perf_args, + const GetPerfOutputCallback& callback) = 0; + // Callback type for GetScrubbedLogs(), GetAllLogs() or GetUserLogFiles(). typedef base::Callback<void(bool succeeded, const std::map<std::string, std::string>& logs)> |