diff options
| author | hashimoto@chromium.org <hashimoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-10 06:19:17 +0000 |
|---|---|---|
| committer | hashimoto@chromium.org <hashimoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-10 06:19:17 +0000 |
| commit | 761eea275b52e1499d9717079597f749f8d87d0a (patch) | |
| tree | 15d206578c52a0af13518c78a9ca47047d1d56ed /chromeos/dbus/debug_daemon_client.h | |
| parent | 987858a12bf45504da0f7d3d47f71caf4cf6339b (diff) | |
| download | chromium_src-761eea275b52e1499d9717079597f749f8d87d0a.zip chromium_src-761eea275b52e1499d9717079597f749f8d87d0a.tar.gz chromium_src-761eea275b52e1499d9717079597f749f8d87d0a.tar.bz2 | |
Use base::File for DebugDaemonClient::GetDebugLogs
There is no need to keep the file descriptor open in net_internals_ui.cc as libdbus duplicates the FD when appropriate.
Use base::File instead of PlatformFile.
Use blocking pool instead of WorkerPool.
BUG=369183
TEST=Can save debug logs in "Chrome OS" section of chrome://net-internals on a Chromebook.
Review URL: https://codereview.chromium.org/270853002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269540 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/dbus/debug_daemon_client.h')
| -rw-r--r-- | chromeos/dbus/debug_daemon_client.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chromeos/dbus/debug_daemon_client.h b/chromeos/dbus/debug_daemon_client.h index fd1da9d..d1ed8b8 100644 --- a/chromeos/dbus/debug_daemon_client.h +++ b/chromeos/dbus/debug_daemon_client.h @@ -6,8 +6,8 @@ #define CHROMEOS_DBUS_DEBUG_DAEMON_CLIENT_H_ #include "base/callback.h" +#include "base/files/file.h" #include "base/memory/ref_counted_memory.h" -#include "base/platform_file.h" #include "chromeos/chromeos_export.h" #include "chromeos/dbus/dbus_client.h" @@ -30,7 +30,7 @@ class CHROMEOS_EXPORT DebugDaemonClient : public DBusClient { // Requests to store debug logs into |file| and calls |callback| // when completed. Debug logs will be stored in the .tgz format. - virtual void GetDebugLogs(base::PlatformFile file, + virtual void GetDebugLogs(base::File file, const GetDebugLogsCallback& callback) = 0; // Called once SetDebugMode() is complete. Takes one parameter: |