diff options
author | pneubeck@chromium.org <pneubeck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-27 12:23:04 +0000 |
---|---|---|
committer | pneubeck@chromium.org <pneubeck@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-27 12:23:04 +0000 |
commit | c5fd536cbf85dea5a3bc200a515bdf6cf75b2576 (patch) | |
tree | 1f233003e6f5d34428c73b318a89454b7c7ee23b /chromeos/dbus/debug_daemon_client.h | |
parent | 072414940357abff52558f794af018adfeb6f0d7 (diff) | |
download | chromium_src-c5fd536cbf85dea5a3bc200a515bdf6cf75b2576.zip chromium_src-c5fd536cbf85dea5a3bc200a515bdf6cf75b2576.tar.gz chromium_src-c5fd536cbf85dea5a3bc200a515bdf6cf75b2576.tar.bz2 |
Split construction and initialization of DBus clients.
Before, each Client had a Create function which constructed an instance of the client and initialized it (with a dbus::Bus*).
To make the Clients separately replaceable in the DBusThreadManager, it's necessary to separate the construction of the Clients from their initialization.
This CL, splits each Create function into Create (which only calls the constructor of either the real Impl or the Stub) and Init(dbus::Bus*).
This is a pure refactoring.
BUG=275286
Review URL: https://chromiumcodereview.appspot.com/23119006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219775 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/dbus/debug_daemon_client.h')
-rw-r--r-- | chromeos/dbus/debug_daemon_client.h | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/chromeos/dbus/debug_daemon_client.h b/chromeos/dbus/debug_daemon_client.h index 7c09a78..711c2cb 100644 --- a/chromeos/dbus/debug_daemon_client.h +++ b/chromeos/dbus/debug_daemon_client.h @@ -9,14 +9,11 @@ #include "base/platform_file.h" #include "base/memory/ref_counted_memory.h" #include "chromeos/chromeos_export.h" +#include "chromeos/dbus/dbus_client.h" #include "chromeos/dbus/dbus_client_implementation_type.h" #include <map> -namespace dbus { -class Bus; -} // namespace dbus - namespace metrics { class PerfDataProto; } @@ -24,7 +21,7 @@ class PerfDataProto; namespace chromeos { // DebugDaemonClient is used to communicate with the debug daemon. -class CHROMEOS_EXPORT DebugDaemonClient { +class CHROMEOS_EXPORT DebugDaemonClient : public DBusClient { public: virtual ~DebugDaemonClient(); @@ -146,8 +143,8 @@ class CHROMEOS_EXPORT DebugDaemonClient { // Factory function, creates a new instance and returns ownership. // For normal usage, access the singleton via DBusThreadManager::Get(). - static DebugDaemonClient* Create(DBusClientImplementationType type, - dbus::Bus* bus); + static DebugDaemonClient* Create(DBusClientImplementationType type); + protected: // Create() should be used instead. DebugDaemonClient(); |