summaryrefslogtreecommitdiffstats
path: root/chromeos/dbus/fake_shill_device_client.cc
diff options
context:
space:
mode:
authorestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-07-16 22:07:47 +0000
committerestade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-07-16 22:07:47 +0000
commitf147ae30413e03b4d7e9486c0f40ca08a8ddeaa1 (patch)
tree1b3909687e54fc87801f780ec5fe1fad1c88e198 /chromeos/dbus/fake_shill_device_client.cc
parentc3eb032875146ba53849bc9fb436c8143bfba63e (diff)
downloadchromium_src-f147ae30413e03b4d7e9486c0f40ca08a8ddeaa1.zip
chromium_src-f147ae30413e03b4d7e9486c0f40ca08a8ddeaa1.tar.gz
chromium_src-f147ae30413e03b4d7e9486c0f40ca08a8ddeaa1.tar.bz2
Get rid of more uses of CreateStringValue
split off from https://codereview.chromium.org/388963002/ BUG=160586 Review URL: https://codereview.chromium.org/390183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283537 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/dbus/fake_shill_device_client.cc')
-rw-r--r--chromeos/dbus/fake_shill_device_client.cc19
1 files changed, 8 insertions, 11 deletions
diff --git a/chromeos/dbus/fake_shill_device_client.cc b/chromeos/dbus/fake_shill_device_client.cc
index bb26d8a..de352b1 100644
--- a/chromeos/dbus/fake_shill_device_client.cc
+++ b/chromeos/dbus/fake_shill_device_client.cc
@@ -242,18 +242,15 @@ void FakeShillDeviceClient::AddDevice(const std::string& device_path,
AddDevice(device_path);
base::DictionaryValue* properties = GetDeviceProperties(device_path);
- properties->SetWithoutPathExpansion(shill::kTypeProperty,
- base::Value::CreateStringValue(type));
- properties->SetWithoutPathExpansion(shill::kNameProperty,
- base::Value::CreateStringValue(name));
- properties->SetWithoutPathExpansion(
- shill::kDBusObjectProperty, base::Value::CreateStringValue(device_path));
- properties->SetWithoutPathExpansion(
- shill::kDBusServiceProperty,
- base::Value::CreateStringValue(modemmanager::kModemManager1ServiceName));
+ properties->SetStringWithoutPathExpansion(shill::kTypeProperty, type);
+ properties->SetStringWithoutPathExpansion(shill::kNameProperty, name);
+ properties->SetStringWithoutPathExpansion(shill::kDBusObjectProperty,
+ device_path);
+ properties->SetStringWithoutPathExpansion(
+ shill::kDBusServiceProperty, modemmanager::kModemManager1ServiceName);
if (type == shill::kTypeCellular) {
- properties->SetWithoutPathExpansion(shill::kCellularAllowRoamingProperty,
- new base::FundamentalValue(false));
+ properties->SetBooleanWithoutPathExpansion(
+ shill::kCellularAllowRoamingProperty, false);
}
}