diff options
author | armansito@chromium.org <armansito@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-04 06:27:12 +0000 |
---|---|---|
committer | armansito@chromium.org <armansito@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-12-04 06:27:12 +0000 |
commit | 35dff5af9f8f18b6b3f4716293f4692dfd46629a (patch) | |
tree | e7977fc2ed1a79e79d9a9823b96945832f801803 /chromeos/dbus/nfc_record_client.h | |
parent | 2552763077180e820e309ebb3fabd6191ad42a41 (diff) | |
download | chromium_src-35dff5af9f8f18b6b3f4716293f4692dfd46629a.zip chromium_src-35dff5af9f8f18b6b3f4716293f4692dfd46629a.tar.gz chromium_src-35dff5af9f8f18b6b3f4716293f4692dfd46629a.tar.bz2 |
nfc: Various fixes to the NFC D-Bus client in chromeos/dbus.
This CL applies the following fixes:
1. Fixed a bug in chromeos::NfcPropertySet::Set where the code didn't pass
in the property name and value to the D-Bus call.
2. Changed NfcTagClient::Write and NfcDeviceClient::Push to take in a
base::DictionaryValue instead of a map of strings for the NDEF attributes,
as the NDEF record attributes don't have string as their only possible
value type.
3. Fixed a regression in DBusThreadManager due to recent refactors that broke
the NFC client initialization code.
4. Allow users of NfcPropertySet to be notified when a call to GetAll completes.
BUG=316471
TEST=chromeos_unittests
Review URL: https://codereview.chromium.org/99903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238604 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/dbus/nfc_record_client.h')
-rw-r--r-- | chromeos/dbus/nfc_record_client.h | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/chromeos/dbus/nfc_record_client.h b/chromeos/dbus/nfc_record_client.h index b514bdb..0a1f158 100644 --- a/chromeos/dbus/nfc_record_client.h +++ b/chromeos/dbus/nfc_record_client.h @@ -91,12 +91,16 @@ class CHROMEOS_EXPORT NfcRecordClient : public DBusClient { // with object path |object_path| has acquired a new value. virtual void RecordPropertyChanged(const dbus::ObjectPath& object_path, const std::string& property_name) {} - }; - // NDEF records can be created via the Tag and Device interfaces by passing a - // dictionary of strings containing the record properties and their values to - // their respective API methods. - typedef std::map<std::string, std::string> Attributes; + // Called when all properties for the record with object path |object_path| + // have been received. This method will be called after + // Observer::RecordPropertyChanged has been called for all properties that + // were received through the initial property fetch that is done when the + // object proxy is first created. Observers can use this method to be + // notified when all existing properties of a record are available for use. + virtual void RecordPropertiesReceived( + const dbus::ObjectPath& object_path) {} + }; virtual ~NfcRecordClient(); |