summaryrefslogtreecommitdiffstats
path: root/chromeos/dbus/shill_manager_client_unittest.cc
diff options
context:
space:
mode:
authorkaliamoorthi <kaliamoorthi@chromium.org>2014-11-13 10:51:04 -0800
committerCommit bot <commit-bot@chromium.org>2014-11-13 18:51:21 +0000
commit4c839047c821a5109fd8b5b828f1ca2082cca07a (patch)
treeb2455d85551c6f71cf9bd7096a8d3e1bd268e5af /chromeos/dbus/shill_manager_client_unittest.cc
parent4771655f7a4798c5021772b4275bac5dd298a7c5 (diff)
downloadchromium_src-4c839047c821a5109fd8b5b828f1ca2082cca07a.zip
chromium_src-4c839047c821a5109fd8b5b828f1ca2082cca07a.tar.gz
chromium_src-4c839047c821a5109fd8b5b828f1ca2082cca07a.tar.bz2
Add new shill client for VPN
This CL adds new shill client for third party vpn dbus interface. BUG=407541 Review URL: https://codereview.chromium.org/681723003 Cr-Commit-Position: refs/heads/master@{#304054}
Diffstat (limited to 'chromeos/dbus/shill_manager_client_unittest.cc')
-rw-r--r--chromeos/dbus/shill_manager_client_unittest.cc18
1 files changed, 12 insertions, 6 deletions
diff --git a/chromeos/dbus/shill_manager_client_unittest.cc b/chromeos/dbus/shill_manager_client_unittest.cc
index a5c6c7a..7f5a13e 100644
--- a/chromeos/dbus/shill_manager_client_unittest.cc
+++ b/chromeos/dbus/shill_manager_client_unittest.cc
@@ -273,10 +273,13 @@ TEST_F(ShillManagerClientTest, ConfigureService) {
writer.AppendObjectPath(object_path);
// Create the argument dictionary.
scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
+ // Use a variant valued dictionary rather than a string valued one.
+ const bool string_valued = false;
// Set expectations.
- PrepareForMethodCall(shill::kConfigureServiceFunction,
- base::Bind(&ExpectDictionaryValueArgument, arg.get()),
- response.get());
+ PrepareForMethodCall(
+ shill::kConfigureServiceFunction,
+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), string_valued),
+ response.get());
// Call method.
MockErrorCallback mock_error_callback;
client_->ConfigureService(*arg,
@@ -297,10 +300,13 @@ TEST_F(ShillManagerClientTest, GetService) {
writer.AppendObjectPath(object_path);
// Create the argument dictionary.
scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
+ // Use a variant valued dictionary rather than a string valued one.
+ const bool string_valued = false;
// Set expectations.
- PrepareForMethodCall(shill::kGetServiceFunction,
- base::Bind(&ExpectDictionaryValueArgument, arg.get()),
- response.get());
+ PrepareForMethodCall(
+ shill::kGetServiceFunction,
+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), string_valued),
+ response.get());
// Call method.
MockErrorCallback mock_error_callback;
client_->GetService(*arg,