summaryrefslogtreecommitdiffstats
path: root/chromeos/dbus
diff options
context:
space:
mode:
authorgauravsh@chromium.org <gauravsh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-18 08:48:22 +0000
committergauravsh@chromium.org <gauravsh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-18 08:48:22 +0000
commit6f974a0d78f3618ddf5e0cb6ba168abd40f235d1 (patch)
tree1ec6308760df2a01df0f8dfd1a96868fb9ce9d4d /chromeos/dbus
parent45392927415cdf9f0823ef9f94e1841ada768aab (diff)
downloadchromium_src-6f974a0d78f3618ddf5e0cb6ba168abd40f235d1.zip
chromium_src-6f974a0d78f3618ddf5e0cb6ba168abd40f235d1.tar.gz
chromium_src-6f974a0d78f3618ddf5e0cb6ba168abd40f235d1.tar.bz2
NetworkPortalDetector/NetworkStateInformer: Switch over to use NetworkStateHandler
This removes the direct network library dependency for NetworkPortalDetector, NetworkStateInformer, and SigninScreenHandler. UpdateScreen and LocallyManagedUserCreationHandler no longer depend on NetworkLibrary as well. Also change active -> default network in these to be consistent with terminology we use in NetworkStateHandler. BUG=189093,189009 Review URL: https://chromiumcodereview.appspot.com/14134007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200968 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/dbus')
-rw-r--r--chromeos/dbus/shill_service_client_stub.cc9
1 files changed, 6 insertions, 3 deletions
diff --git a/chromeos/dbus/shill_service_client_stub.cc b/chromeos/dbus/shill_service_client_stub.cc
index af4245c..d4e131d 100644
--- a/chromeos/dbus/shill_service_client_stub.cc
+++ b/chromeos/dbus/shill_service_client_stub.cc
@@ -106,10 +106,13 @@ void ShillServiceClientStub::SetProperty(const dbus::ObjectPath& service_path,
return;
}
if (name == flimflam::kStateProperty) {
- // If we connect to a service, then we move it to the top of the list in
- // the manager client.
+ // If the service went into a connected state, then move it to the top of
+ // the list in the manager client.
+ // TODO(gauravsh): Generalize to sort services properly to allow for testing
+ // more complex scenarios.
std::string state;
- if (value.GetAsString(&state) && state == flimflam::kStateOnline) {
+ if (value.GetAsString(&state) && (state == flimflam::kStateOnline ||
+ state == flimflam::kStatePortal)) {
ShillManagerClient* manager_client =
DBusThreadManager::Get()->GetShillManagerClient();
manager_client->GetTestInterface()->MoveServiceToIndex(