diff options
author | smckay <smckay@chromium.org> | 2015-02-06 12:07:12 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-02-06 20:08:11 +0000 |
commit | 873d9c13d08de9449b659fd5dad1fcf579758a3a (patch) | |
tree | 966f3f3ef64bd1b4f97e1465b2268c78a15e6c0e /chromeos/dbus | |
parent | e2697a79da9e5cde038c6fcb58a5e414c57c306a (diff) | |
download | chromium_src-873d9c13d08de9449b659fd5dad1fcf579758a3a.zip chromium_src-873d9c13d08de9449b659fd5dad1fcf579758a3a.tar.gz chromium_src-873d9c13d08de9449b659fd5dad1fcf579758a3a.tar.bz2 |
1) Add a drop down revealing a popup panel with import details (with is a WIP, but the current state should be sufficient to land).
2) Update scanner to publish updates on all scan activity (so the details reflects valid information while scanning). In doing this I pulled all of the deduping logic up out of ScanResult into MediaScanner...improving separation of concern between the classes.
3) Rework update model to eliminate a flicker resulting from the brief update to show zero results when a file selection is transitioning from n to n+/-1.
Sadly, this change results in a net loss of readability, especially WRT having good clear decision points. I've added comments to help out in this respect.
FYI, I'm OOO for the rest of the day. I think this CL is good to land, rough though it may be.
In a followup CL:
1) I'll make some subsequent improvements to unittests in the wake of removing the "GetCommandUpdate" coverage (removed because GetCommandUpdate exists no more).
2) This change still exhibits one odd behavior, ignoring entirely a selection when it consistes of all deduped files...in that case we *do* want to see zero results. Will address at the time of test improvements.
BUG=420680
TEST=browser_test: FileManagerJsTest.*
Review URL: https://codereview.chromium.org/899943002
Cr-Commit-Position: refs/heads/master@{#315094}
Diffstat (limited to 'chromeos/dbus')
0 files changed, 0 insertions, 0 deletions