summaryrefslogtreecommitdiffstats
path: root/chromeos/dbus
diff options
context:
space:
mode:
authorharuki@chromium.org <haruki@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-23 05:11:12 +0000
committerharuki@chromium.org <haruki@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-23 05:11:12 +0000
commitcc92d431e063081d78cd66d9978d6a81c2b84fde (patch)
tree3c4ae9fa84d0a65315f92e4a2ee8d04595abd984 /chromeos/dbus
parent180e950f9e1cd48ada5e25859acaefd490a1d168 (diff)
downloadchromium_src-cc92d431e063081d78cd66d9978d6a81c2b84fde.zip
chromium_src-cc92d431e063081d78cd66d9978d6a81c2b84fde.tar.gz
chromium_src-cc92d431e063081d78cd66d9978d6a81c2b84fde.tar.bz2
dbus: Add and fix comments in MockDBusThreadManager*
BUG=223061 TEST=no effect. comment changes only. Review URL: https://codereview.chromium.org/14397002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195714 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/dbus')
-rw-r--r--chromeos/dbus/mock_dbus_thread_manager.h2
-rw-r--r--chromeos/dbus/mock_dbus_thread_manager_without_gmock.h6
2 files changed, 6 insertions, 2 deletions
diff --git a/chromeos/dbus/mock_dbus_thread_manager.h b/chromeos/dbus/mock_dbus_thread_manager.h
index 5290988..233b931 100644
--- a/chromeos/dbus/mock_dbus_thread_manager.h
+++ b/chromeos/dbus/mock_dbus_thread_manager.h
@@ -55,6 +55,8 @@ class PowerPolicyController;
// This class provides a mock DBusThreadManager with mock clients
// installed. You can customize the behaviors of mock clients with
// mock_foo_client() functions.
+// Please avoid adding more GMock in this class. We have an ongoing effort to
+// remove GMock dependency. TODO(haruki): crbug.com/223061.
class MockDBusThreadManager : public DBusThreadManager {
public:
MockDBusThreadManager();
diff --git a/chromeos/dbus/mock_dbus_thread_manager_without_gmock.h b/chromeos/dbus/mock_dbus_thread_manager_without_gmock.h
index fecdf54..c3f4088 100644
--- a/chromeos/dbus/mock_dbus_thread_manager_without_gmock.h
+++ b/chromeos/dbus/mock_dbus_thread_manager_without_gmock.h
@@ -32,8 +32,10 @@ class MockIBusInputContextClient;
class MockIBusPanelService;
// This class provides an another mock DBusThreadManager without gmock
-// dependency. This class is used only for places where GMock is not allowed
-// (ex. ui/).
+// dependency. This class is used for places where GMock is not allowed
+// (ex. ui/) or is not used.
+// TODO(haruki): Along with crbug.com/223061, we can rename this class to
+// clarify that this can also provides fakes and stubs.
class MockDBusThreadManagerWithoutGMock : public DBusThreadManager {
public:
MockDBusThreadManagerWithoutGMock();