diff options
| author | ki.stfu <ki.stfu@gmail.com> | 2015-09-21 17:56:52 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-09-22 00:57:25 +0000 |
| commit | d3709b5f91fe5d0d4accd7386da5a61743824b9e (patch) | |
| tree | ffd618fc74a2588a96fc42be809f0dbf5ee0a93f /chromeos/dbus | |
| parent | 15b28d658c5a66655c19a7299f2e50fcd7b591c3 (diff) | |
| download | chromium_src-d3709b5f91fe5d0d4accd7386da5a61743824b9e.zip chromium_src-d3709b5f91fe5d0d4accd7386da5a61743824b9e.tar.gz chromium_src-d3709b5f91fe5d0d4accd7386da5a61743824b9e.tar.bz2 | |
Cleanup: Pass std::string as const reference from chromeos/
Passing std::string by reference can prevent extra copying of object.
BUG=367418
TEST=
R=zelidrag@chromium.org,derat@chromium.org,gauravsh@chromium.org
Review URL: https://codereview.chromium.org/1353323002
Cr-Commit-Position: refs/heads/master@{#350078}
Diffstat (limited to 'chromeos/dbus')
| -rw-r--r-- | chromeos/dbus/fake_shill_manager_client.cc | 5 | ||||
| -rw-r--r-- | chromeos/dbus/fake_shill_manager_client.h | 3 |
2 files changed, 5 insertions, 3 deletions
diff --git a/chromeos/dbus/fake_shill_manager_client.cc b/chromeos/dbus/fake_shill_manager_client.cc index 337041b..ca7c6a5 100644 --- a/chromeos/dbus/fake_shill_manager_client.cc +++ b/chromeos/dbus/fake_shill_manager_client.cc @@ -1115,8 +1115,9 @@ bool FakeShillManagerClient::ParseOption(const std::string& arg0, return SetInitialNetworkState(arg0, arg1); } -bool FakeShillManagerClient::SetInitialNetworkState(std::string type_arg, - std::string state_arg) { +bool FakeShillManagerClient::SetInitialNetworkState( + std::string type_arg, + const std::string& state_arg) { int state_arg_as_int = -1; base::StringToInt(state_arg, &state_arg_as_int); diff --git a/chromeos/dbus/fake_shill_manager_client.h b/chromeos/dbus/fake_shill_manager_client.h index 313a2d4..f677350 100644 --- a/chromeos/dbus/fake_shill_manager_client.h +++ b/chromeos/dbus/fake_shill_manager_client.h @@ -126,7 +126,8 @@ class CHROMEOS_EXPORT FakeShillManagerClient // {wifi,cellular,etc}={on,off,disabled,none} - sets initial state for type void ParseCommandLineSwitch(); bool ParseOption(const std::string& arg0, const std::string& arg1); - bool SetInitialNetworkState(std::string type_arg, std::string state_arg); + bool SetInitialNetworkState(std::string type_arg, + const std::string& state_arg); std::string GetInitialStateForType(const std::string& type, bool* enabled); |