diff options
| author | stevenjb@chromium.org <stevenjb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-13 18:38:37 +0000 |
|---|---|---|
| committer | stevenjb@chromium.org <stevenjb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-13 18:38:37 +0000 |
| commit | e925cfd07d98f3329c60ef95b0679467166c9b67 (patch) | |
| tree | d9879a19c53e46eb594042e30d1d7ddaec17b70c /chromeos/network/shill_property_handler.h | |
| parent | 3b3301fb847275f91fc48249dd29867793b83f46 (diff) | |
| download | chromium_src-e925cfd07d98f3329c60ef95b0679467166c9b67.zip chromium_src-e925cfd07d98f3329c60ef95b0679467166c9b67.tar.gz chromium_src-e925cfd07d98f3329c60ef95b0679467166c9b67.tar.bz2 | |
Eliminate NetworkManagerChanged
This observer is unnecessary, confusing, and frequently misused.
See issue for background / details
BUG=288196
For chrome/browser/ui/webui/chromeos/login/
R=pneubeck@chromium.org
TBR=xiyuan@chromium.org
Review URL: https://codereview.chromium.org/23684042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223091 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/network/shill_property_handler.h')
| -rw-r--r-- | chromeos/network/shill_property_handler.h | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/chromeos/network/shill_property_handler.h b/chromeos/network/shill_property_handler.h index cc9133b..2b96a8c 100644 --- a/chromeos/network/shill_property_handler.h +++ b/chromeos/network/shill_property_handler.h @@ -75,9 +75,8 @@ class CHROMEOS_EXPORT ShillPropertyHandler virtual void CheckPortalListChanged( const std::string& check_portal_list) = 0; - // Called when one or more manager properties (e.g. a technology list) - // changes. - virtual void NotifyManagerPropertyChanged() = 0; + // Called when a technology list changes. + virtual void TechnologyListChanged() = 0; // Called when a managed state list has changed, after properties for any // new entries in the list have been received and @@ -143,8 +142,7 @@ class CHROMEOS_EXPORT ShillPropertyHandler void CheckPendingStateListUpdates(const std::string& key); // Called form OnPropertyChanged() and ManagerPropertiesCallback(). - // Returns true if observers should be notified. - bool ManagerPropertyChanged(const std::string& key, + void ManagerPropertyChanged(const std::string& key, const base::Value& value); // Requests properties for new entries in the list for |type| as follows: |