diff options
| author | rsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-10 21:44:11 +0000 |
|---|---|---|
| committer | rsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-04-10 21:44:11 +0000 |
| commit | 92abd732b8bc37fe97dce45e2a067a7dda96d0ad (patch) | |
| tree | a95786f9e23e53362fe07109d2289202467cfc82 /chromeos/process_proxy | |
| parent | a49151501ebc512f0c2caffe35ddeafd89fff046 (diff) | |
| download | chromium_src-92abd732b8bc37fe97dce45e2a067a7dda96d0ad.zip chromium_src-92abd732b8bc37fe97dce45e2a067a7dda96d0ad.tar.gz chromium_src-92abd732b8bc37fe97dce45e2a067a7dda96d0ad.tar.bz2 | |
[ChromeOS] Don't set NO_NEW_PRIVS for ProcessProxy processes (e.g. Crosh) when in dev-mode.
BUG=358713
TEST=Put system in dev mode, open Crosh, type `shell`, and run sudo.
Review URL: https://codereview.chromium.org/228783005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263092 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos/process_proxy')
| -rw-r--r-- | chromeos/process_proxy/process_proxy.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chromeos/process_proxy/process_proxy.cc b/chromeos/process_proxy/process_proxy.cc index 5aa373f..aae2ee9 100644 --- a/chromeos/process_proxy/process_proxy.cc +++ b/chromeos/process_proxy/process_proxy.cc @@ -17,6 +17,7 @@ #include "base/process/launch.h" #include "base/threading/thread.h" #include "chromeos/process_proxy/process_output_watcher.h" +#include "third_party/cros_system_api/switches/chrome_switches.h" namespace { @@ -223,6 +224,10 @@ bool ProcessProxy::LaunchProcess(const std::string& command, int slave_fd, fds_mapping.push_back(std::make_pair(slave_fd, STDOUT_FILENO)); fds_mapping.push_back(std::make_pair(slave_fd, STDERR_FILENO)); base::LaunchOptions options; + // Do not set NO_NEW_PRIVS on processes if the system is in dev-mode. This + // permits sudo in the crosh shell when in developer mode. + options.allow_new_privs = base::CommandLine::ForCurrentProcess()-> + HasSwitch(chromeos::switches::kSystemInDevMode); options.fds_to_remap = &fds_mapping; options.ctrl_terminal_fd = slave_fd; options.environ["TERM"] = "xterm"; |