diff options
author | shuchen@chromium.org <shuchen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-21 15:43:37 +0000 |
---|---|---|
committer | shuchen@chromium.org <shuchen@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-21 15:43:37 +0000 |
commit | 125852dc578fa0824cc536eb0fd62eb5fc6a72cc (patch) | |
tree | 1a44fc179f05e88a88b087871d4ed2d59d1e3d41 /chromeos | |
parent | c6ee54dcccce58f999f278a613b63a154d539fbc (diff) | |
download | chromium_src-125852dc578fa0824cc536eb0fd62eb5fc6a72cc.zip chromium_src-125852dc578fa0824cc536eb0fd62eb5fc6a72cc.tar.gz chromium_src-125852dc578fa0824cc536eb0fd62eb5fc6a72cc.tar.bz2 |
[IME] Fix the issue that component IME extension doesn't support split options page for each input_component.
BUG=334527
TEST=Verified on pixel device
TBR=yukishiino@chromium.org
Review URL: https://codereview.chromium.org/207523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258593 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos')
-rw-r--r-- | chromeos/ime/component_extension_ime_manager.cc | 4 | ||||
-rw-r--r-- | chromeos/ime/component_extension_ime_manager.h | 3 |
2 files changed, 4 insertions, 3 deletions
diff --git a/chromeos/ime/component_extension_ime_manager.cc b/chromeos/ime/component_extension_ime_manager.cc index e39537a..d34ef19 100644 --- a/chromeos/ime/component_extension_ime_manager.cc +++ b/chromeos/ime/component_extension_ime_manager.cc @@ -203,8 +203,8 @@ input_method::InputMethodDescriptors // Enables extension based xkb keyboards on login screen. extension_ime_util::IsKeyboardLayoutExtension( input_method_id) && IsInLoginLayoutWhitelist(layouts), - component_extension_imes_[i].options_page_url, - component_extension_imes_[i].input_view_url)); + component_extension_imes_[i].engines[j].options_page_url, + component_extension_imes_[i].engines[j].input_view_url)); } } return result; diff --git a/chromeos/ime/component_extension_ime_manager.h b/chromeos/ime/component_extension_ime_manager.h index bc26ec6..11f113f 100644 --- a/chromeos/ime/component_extension_ime_manager.h +++ b/chromeos/ime/component_extension_ime_manager.h @@ -24,6 +24,8 @@ struct CHROMEOS_EXPORT ComponentExtensionEngine { std::vector<std::string> language_codes; // The engine's language(ex. "en"). std::string description; // The engine description. std::vector<std::string> layouts; // The list of keyboard layout of engine. + GURL options_page_url; // an URL to option page. + GURL input_view_url; // an URL to input view page. }; // Represents a component extension IME. @@ -34,7 +36,6 @@ struct CHROMEOS_EXPORT ComponentExtensionIME { std::string manifest; // the contents of manifest.json std::string description; // description of extension. GURL options_page_url; // an URL to option page. - GURL input_view_url; // an URL to input view page. base::FilePath path; std::vector<ComponentExtensionEngine> engines; }; |