diff options
author | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-12 01:59:02 +0000 |
---|---|---|
committer | hans@chromium.org <hans@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-12 01:59:02 +0000 |
commit | 1d51882f44178fb5bdbf6a7f31e435c9d6de652a (patch) | |
tree | 97388deda6011a2d2897a8d4eea831a6bc56b568 /chromeos | |
parent | 9e9a06a3d002a799246a5dbbd9d95aef999185c9 (diff) | |
download | chromium_src-1d51882f44178fb5bdbf6a7f31e435c9d6de652a.zip chromium_src-1d51882f44178fb5bdbf6a7f31e435c9d6de652a.tar.gz chromium_src-1d51882f44178fb5bdbf6a7f31e435c9d6de652a.tar.bz2 |
Fixes for -Wunused-function on Linux, Android and ChromeOS
BUG=315884, 78045
TBR=owners
Review URL: https://codereview.chromium.org/67923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234373 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos')
-rw-r--r-- | chromeos/dbus/fake_shill_service_client.cc | 5 | ||||
-rw-r--r-- | chromeos/ime/ibus_daemon_controller.cc | 35 | ||||
-rw-r--r-- | chromeos/network/onc/onc_validator.cc | 6 |
3 files changed, 0 insertions, 46 deletions
diff --git a/chromeos/dbus/fake_shill_service_client.cc b/chromeos/dbus/fake_shill_service_client.cc index 19ab3d6..c968d80e 100644 --- a/chromeos/dbus/fake_shill_service_client.cc +++ b/chromeos/dbus/fake_shill_service_client.cc @@ -26,11 +26,6 @@ namespace chromeos { namespace { -void ErrorFunction(const std::string& error_name, - const std::string& error_message) { - LOG(ERROR) << "Shill Error: " << error_name << " : " << error_message; -} - void PassStubListValue(const ShillServiceClient::ListValueCallback& callback, base::ListValue* value) { callback.Run(*value); diff --git a/chromeos/ime/ibus_daemon_controller.cc b/chromeos/ime/ibus_daemon_controller.cc index 01cd583..7febb2b 100644 --- a/chromeos/ime/ibus_daemon_controller.cc +++ b/chromeos/ime/ibus_daemon_controller.cc @@ -17,41 +17,6 @@ namespace chromeos { namespace { IBusDaemonController* g_ibus_daemon_controller = NULL; -base::FilePathWatcher* g_file_path_watcher = NULL; - -// Called when the ibus-daemon address file is modified. -static void OnFilePathChanged( - const scoped_refptr<base::SequencedTaskRunner> ui_task_runner, - const base::Closure& closure, - const base::FilePath& file_path, - bool failed) { - if (failed) - return; // Can't recover, do nothing. - if (!g_file_path_watcher) - return; // Already discarded watch task. - - ui_task_runner->PostTask(FROM_HERE, closure); - ui_task_runner->DeleteSoon(FROM_HERE, g_file_path_watcher); - g_file_path_watcher = NULL; -} - -// Start watching |address_file_path|. If the target file is changed, |callback| -// is called on UI thread. This function should be called on FILE thread. -void StartWatch( - const std::string& address_file_path, - const base::Closure& closure, - const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner) { - // Before start watching, discard on-going watching task. - delete g_file_path_watcher; - g_file_path_watcher = new base::FilePathWatcher; - bool result = g_file_path_watcher->Watch( - base::FilePath::FromUTF8Unsafe(address_file_path), - false, // do not watch child directory. - base::Bind(&OnFilePathChanged, - ui_task_runner, - closure)); - DCHECK(result); -} // An implementation of IBusDaemonController without ibus-daemon interaction. // Currently this class is used only on linux desktop. diff --git a/chromeos/network/onc/onc_validator.cc b/chromeos/network/onc/onc_validator.cc index 29e58ac..d1d4c52 100644 --- a/chromeos/network/onc/onc_validator.cc +++ b/chromeos/network/onc/onc_validator.cc @@ -20,12 +20,6 @@ namespace onc { namespace { -std::string ValueToString(const base::Value& value) { - std::string json; - base::JSONWriter::Write(&value, &json); - return json; -} - // Copied from policy/configuration_policy_handler.cc. // TODO(pneubeck): move to a common place like base/. std::string ValueTypeToString(base::Value::Type type) { |