diff options
| author | gcasto <gcasto@chromium.org> | 2015-05-07 13:38:57 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-05-07 20:39:38 +0000 |
| commit | 31cb2f54016707d90a028d7b1d9ccfee7f681a1c (patch) | |
| tree | de95fc9d955e5ed321cfaf324b08581b06abb19f /chromeos | |
| parent | 90381080725cb6452fe4f8a8f703717a585b2f23 (diff) | |
| download | chromium_src-31cb2f54016707d90a028d7b1d9ccfee7f681a1c.zip chromium_src-31cb2f54016707d90a028d7b1d9ccfee7f681a1c.tar.gz chromium_src-31cb2f54016707d90a028d7b1d9ccfee7f681a1c.tar.bz2 | |
Revert of Move CronetTestBase#prepareTestStorage to CronetTestActivity (patchset #6 id:120001 of https://codereview.chromium.org/1120063003/)
Reason for revert:
Possible culprit for compilation failure (http://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builder%20%28dbg%29/builds/59208/steps/compile/logs/stdio)
Original issue's description:
> Move CronetTestBase#prepareTestStorage to CronetTestActivity
>
> prepareTestStorage() is sometimes called before activity is
> launched to initialize UrlRequestContextConfig. This
> creates a race where we call PathUtils#getDataDirectory
> before PathUtils#setPrivateDataDirectorySuffix is invoked in
> CronetTestApplication#onCreate. This CL moves
> prepareTestStorage to activity to avoid this race.
>
> This CL also initializes
> CronetTestActivity.mStreamHandlerFactory when needed.
> This is to avoid having two live CronetUrlRequestContexts
> at once.
> BUG=482813, 485100
>
> Committed: https://crrev.com/743ec3bdabdd1b0dd0813d42aea00020a2e25b3b
> Cr-Commit-Position: refs/heads/master@{#328816}
TBR=mef@chromium.org,xunjieli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=482813, 485100
Review URL: https://codereview.chromium.org/1136573003
Cr-Commit-Position: refs/heads/master@{#328819}
Diffstat (limited to 'chromeos')
0 files changed, 0 insertions, 0 deletions