diff options
author | msw <msw@chromium.org> | 2016-02-02 17:25:06 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-03 01:26:34 +0000 |
commit | 456d842422a8cf9954ebeab7615059a0129812de (patch) | |
tree | 66113703585a40588dcb52d8bbf779805b8f3788 /chromeos | |
parent | 91375c125e08b6b53bb7c7e3eaedab1ef7c08a0b (diff) | |
download | chromium_src-456d842422a8cf9954ebeab7615059a0129812de.zip chromium_src-456d842422a8cf9954ebeab7615059a0129812de.tar.gz chromium_src-456d842422a8cf9954ebeab7615059a0129812de.tar.bz2 |
Revert of Delete base/prefs and update callers to use components. (patchset #3 id:40001 of https://codereview.chromium.org/1662523004/ )
Reason for revert:
Broke Win Builder compile:
https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/19463/steps/compile/logs/stdio
Original issue's description:
> Delete base/prefs and update callers to use components.
>
> Deletes the forwarding headers in base/prefs.
>
> Updates the remaining users of base/prefs includes to use components/prefs.
> Sort headers in updated files.
>
> Move PrefServiceFactory out of the base namespace. Update users.
>
> Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
> COMPONENTS_PREFS_.
>
> Add components/prefs to DEPS file of directories where checkdeps fails after
> the update.
>
> BUG=583034
>
> Committed: https://crrev.com/1f5feb7e317e3c257090858e950273b64a2e31ef
> Cr-Commit-Position: refs/heads/master@{#373105}
TBR=estade@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583034
Review URL: https://codereview.chromium.org/1662843002
Cr-Commit-Position: refs/heads/master@{#373115}
Diffstat (limited to 'chromeos')
-rw-r--r-- | chromeos/DEPS | 1 | ||||
-rw-r--r-- | chromeos/audio/audio_devices_pref_handler_impl.cc | 6 | ||||
-rw-r--r-- | chromeos/audio/audio_devices_pref_handler_impl.h | 2 | ||||
-rw-r--r-- | chromeos/audio/audio_devices_pref_handler_impl_unittest.cc | 2 | ||||
-rw-r--r-- | chromeos/login/auth/login_performer.cc | 2 | ||||
-rw-r--r-- | chromeos/timezone/timezone_resolver.cc | 4 |
6 files changed, 8 insertions, 9 deletions
diff --git a/chromeos/DEPS b/chromeos/DEPS index f55569a..ecef880 100644 --- a/chromeos/DEPS +++ b/chromeos/DEPS @@ -3,7 +3,6 @@ # be kept as small as possible. include_rules = [ "+components/device_event_log", - "+components/prefs", "+crypto", "+net", "+policy/proto", diff --git a/chromeos/audio/audio_devices_pref_handler_impl.cc b/chromeos/audio/audio_devices_pref_handler_impl.cc index 61b2fc5..3f95829 100644 --- a/chromeos/audio/audio_devices_pref_handler_impl.cc +++ b/chromeos/audio/audio_devices_pref_handler_impl.cc @@ -11,12 +11,12 @@ #include "base/bind.h" #include "base/bind_helpers.h" #include "base/logging.h" +#include "base/prefs/pref_registry_simple.h" +#include "base/prefs/pref_service.h" +#include "base/prefs/scoped_user_pref_update.h" #include "base/strings/string_number_conversions.h" #include "chromeos/audio/audio_device.h" #include "chromeos/chromeos_pref_names.h" -#include "components/prefs/pref_registry_simple.h" -#include "components/prefs/pref_service.h" -#include "components/prefs/scoped_user_pref_update.h" namespace { diff --git a/chromeos/audio/audio_devices_pref_handler_impl.h b/chromeos/audio/audio_devices_pref_handler_impl.h index 7e30e59..c2132db 100644 --- a/chromeos/audio/audio_devices_pref_handler_impl.h +++ b/chromeos/audio/audio_devices_pref_handler_impl.h @@ -9,10 +9,10 @@ #include "base/macros.h" #include "base/observer_list.h" +#include "base/prefs/pref_change_registrar.h" #include "base/values.h" #include "chromeos/audio/audio_devices_pref_handler.h" #include "chromeos/chromeos_export.h" -#include "components/prefs/pref_change_registrar.h" class PrefRegistrySimple; class PrefService; diff --git a/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc b/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc index c0ffe80..dea358f 100644 --- a/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc +++ b/chromeos/audio/audio_devices_pref_handler_impl_unittest.cc @@ -8,11 +8,11 @@ #include "base/macros.h" #include "base/memory/ref_counted.h" +#include "base/prefs/testing_pref_service.h" #include "chromeos/audio/audio_device.h" #include "chromeos/audio/audio_devices_pref_handler.h" #include "chromeos/chromeos_pref_names.h" #include "chromeos/dbus/audio_node.h" -#include "components/prefs/testing_pref_service.h" #include "testing/gtest/include/gtest/gtest.h" namespace chromeos { diff --git a/chromeos/login/auth/login_performer.cc b/chromeos/login/auth/login_performer.cc index 080084f..f5a1f76 100644 --- a/chromeos/login/auth/login_performer.cc +++ b/chromeos/login/auth/login_performer.cc @@ -10,6 +10,7 @@ #include "base/metrics/histogram.h" #include "base/metrics/user_metrics.h" #include "base/metrics/user_metrics_action.h" +#include "base/prefs/pref_service.h" #include "base/strings/utf_string_conversions.h" #include "base/threading/thread_restrictions.h" #include "chromeos/dbus/dbus_thread_manager.h" @@ -17,7 +18,6 @@ #include "chromeos/login/user_names.h" #include "chromeos/login_event_recorder.h" #include "chromeos/settings/cros_settings_names.h" -#include "components/prefs/pref_service.h" #include "components/signin/core/account_id/account_id.h" #include "google_apis/gaia/gaia_auth_util.h" #include "net/cookies/cookie_monster.h" diff --git a/chromeos/timezone/timezone_resolver.cc b/chromeos/timezone/timezone_resolver.cc index c6ebfb4..5938654 100644 --- a/chromeos/timezone/timezone_resolver.cc +++ b/chromeos/timezone/timezone_resolver.cc @@ -15,14 +15,14 @@ #include "base/macros.h" #include "base/power_monitor/power_monitor.h" #include "base/power_monitor/power_observer.h" +#include "base/prefs/pref_registry_simple.h" +#include "base/prefs/pref_service.h" #include "base/rand_util.h" #include "base/strings/utf_string_conversions.h" #include "base/time/time.h" #include "chromeos/geolocation/geoposition.h" #include "chromeos/geolocation/simple_geolocation_provider.h" #include "chromeos/timezone/timezone_provider.h" -#include "components/prefs/pref_registry_simple.h" -#include "components/prefs/pref_service.h" namespace chromeos { |