summaryrefslogtreecommitdiffstats
path: root/chromeos
diff options
context:
space:
mode:
authorstevenjb@chromium.org <stevenjb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-08-20 09:49:57 +0000
committerstevenjb@chromium.org <stevenjb@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-08-20 09:51:14 +0000
commit791d0e37bfcbe133c0b6a651609a08003d1c3b81 (patch)
treec5645e7f95cb861db02837f06670ece7f237ab07 /chromeos
parent558bdb6da1b74cdb1ae8bbb86223e494c02dc9c6 (diff)
downloadchromium_src-791d0e37bfcbe133c0b6a651609a08003d1c3b81.zip
chromium_src-791d0e37bfcbe133c0b6a651609a08003d1c3b81.tar.gz
chromium_src-791d0e37bfcbe133c0b6a651609a08003d1c3b81.tar.bz2
Replace ONC crash on Release with ERROR, crash on Debug
BUG=404708 Review URL: https://codereview.chromium.org/489603002 Cr-Commit-Position: refs/heads/master@{#290798} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290798 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chromeos')
-rw-r--r--chromeos/network/onc/onc_translator_shill_to_onc.cc6
1 files changed, 4 insertions, 2 deletions
diff --git a/chromeos/network/onc/onc_translator_shill_to_onc.cc b/chromeos/network/onc/onc_translator_shill_to_onc.cc
index dc01b2a..19e7eff 100644
--- a/chromeos/network/onc/onc_translator_shill_to_onc.cc
+++ b/chromeos/network/onc/onc_translator_shill_to_onc.cc
@@ -398,8 +398,10 @@ void ShillToONCTranslator::TranslateAndAddNestedObject(
const base::DictionaryValue& dictionary) {
const OncFieldSignature* field_signature =
GetFieldSignature(*onc_signature_, onc_field_name);
- DCHECK(field_signature) << "Unable to find signature for field "
- << onc_field_name << ".";
+ if (!field_signature) {
+ NOTREACHED() << "Unable to find signature for field: " << onc_field_name;
+ return;
+ }
ShillToONCTranslator nested_translator(dictionary,
*field_signature->value_signature);
scoped_ptr<base::DictionaryValue> nested_object =