diff options
| author | thakis <thakis@chromium.org> | 2015-12-09 16:36:25 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-12-10 00:37:07 +0000 |
| commit | 9230c1d2dc9af55c573c54b64780a75cf418d896 (patch) | |
| tree | 42d7eaf8c2d6952b6fce4222988d99a382f92f58 /cloud_print | |
| parent | defcc73ab06beb476b98403f8d5d4a4b065fd97b (diff) | |
| download | chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.zip chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.tar.gz chromium_src-9230c1d2dc9af55c573c54b64780a75cf418d896.tar.bz2 | |
clang/win: Let some chromium_code targets build with -Wextra.
To make warning flags between Windows and non-Windows clang consistent,
I'd like to build chromium_code targets with -Wextra enabled. This fixes
-Wextra warnings in about 14k of 31k build steps.
Most of the warnings were about signed/unsigned mismatches; some were about
"const"s that had no effect.
(This CL does not contain the change to actually turn on -Wextra, only
cleanups.)
BUG=567877
TBR=content/common/sandbox
Review URL: https://codereview.chromium.org/1507413003
Cr-Commit-Position: refs/heads/master@{#364232}
Diffstat (limited to 'cloud_print')
| -rw-r--r-- | cloud_print/virtual_driver/win/install/setup.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cloud_print/virtual_driver/win/install/setup.cc b/cloud_print/virtual_driver/win/install/setup.cc index 9032258..c7fc3a5 100644 --- a/cloud_print/virtual_driver/win/install/setup.cc +++ b/cloud_print/virtual_driver/win/install/setup.cc @@ -193,7 +193,7 @@ UINT CALLBACK CabinetCallback(PVOID data, if (notification == SPFILENOTIFY_FILEINCABINET) { FILE_IN_CABINET_INFO* info = reinterpret_cast<FILE_IN_CABINET_INFO*>(param1); - for (int i = 0; i < arraysize(kDependencyList); i++) { + for (size_t i = 0; i < arraysize(kDependencyList); i++) { base::FilePath base_name(info->NameInCabinet); base_name = base_name.BaseName(); if (base::FilePath::CompareEqualIgnoreCase(base_name.value().c_str(), |