diff options
| author | sdefresne <sdefresne@chromium.org> | 2015-03-02 02:33:08 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-02 10:33:38 +0000 |
| commit | 4fb46b5b522e018429b2e40cf5f1c037c3ebbe19 (patch) | |
| tree | 4c3dcc6a260f774893bae64c72373720c223ea64 /components/BUILD.gn | |
| parent | 8747aee1f18410d8eaf0e2d98724c8e24477bdc2 (diff) | |
| download | chromium_src-4fb46b5b522e018429b2e40cf5f1c037c3ebbe19.zip chromium_src-4fb46b5b522e018429b2e40cf5f1c037c3ebbe19.tar.gz chromium_src-4fb46b5b522e018429b2e40cf5f1c037c3ebbe19.tar.bz2 | |
Revert of Remove dependency on //components/feedback on iOS (patchset #1 id:1 of https://codereview.chromium.org/954943004/)
Reason for revert:
This CL cause the test to run in another order, causing a hidden dependency on the ordering to be visible. Reverting as this cause test failures.
See http://crbug.com/462352
Original issue's description:
> Remove dependency on //components/feedback on iOS
>
> iOS does not use //components/feedback to report feedback so remove
> the unused dependencies.
>
> BUG=None
>
> Committed: https://crrev.com/3e96329f442c10d73174688a4786ab847a49a37f
> Cr-Commit-Position: refs/heads/master@{#318211}
TBR=thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/968653004
Cr-Commit-Position: refs/heads/master@{#318674}
Diffstat (limited to 'components/BUILD.gn')
| -rw-r--r-- | components/BUILD.gn | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/components/BUILD.gn b/components/BUILD.gn index 95b02c9..d7cd5cf 100644 --- a/components/BUILD.gn +++ b/components/BUILD.gn @@ -40,6 +40,7 @@ group("all_components") { "//components/enhanced_bookmarks", "//components/favicon/core", "//components/favicon_base", + "//components/feedback", "//components/gcm_driver", "//components/google/core/browser", "//components/history/content/browser", @@ -161,6 +162,7 @@ group("all_components") { "//components/domain_reliability", # Blocked on content. "//components/favicon_base", # Should work, needs checking. "//components/favicon/core", # Blocked on keyed service. + "//components/feedback", # Blocked on content. "//components/gcm_driver", # Should work, needs checking. "//components/google/core/browser", # Should work, needs checking. "//components/history/core/browser", # Should work, needs checking. @@ -202,7 +204,6 @@ group("all_components") { if (!is_ios && !is_android) { deps += [ "//components/copresence", - "//components/feedback", "//components/storage_monitor", ] } |