diff options
| author | vabr <vabr@chromium.org> | 2016-01-20 06:04:33 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-01-20 14:06:27 +0000 |
| commit | 91c0984d84f16caa19a459e0cb327591ef90c9ec (patch) | |
| tree | 1c09d14b20298d088272c4068abf4f8d3b74b7b4 /components/autofill.gypi | |
| parent | 59114d2d8e4af518ad143371ac8445cb6bfad06b (diff) | |
| download | chromium_src-91c0984d84f16caa19a459e0cb327591ef90c9ec.zip chromium_src-91c0984d84f16caa19a459e0cb327591ef90c9ec.tar.gz chromium_src-91c0984d84f16caa19a459e0cb327591ef90c9ec.tar.bz2 | |
Extract CountryNames and CountryDataMap into separate files
This is a clean-up to separate the 3 functional groups bundled in
autofill_country.cc. It will make testing easier once the locale string stops
being passed through AutofillCountry to CountryNames.
This CL contains no functional changes.
This CL also simplifies the CountryDataMap API by exposing the contained map
directly rather than through custom Begin, End and Find. This allows to use
range-based loops on CountryDataMap contents.
The CL also removes AutofillCountry::GetAvailableCountries in favour of using CountryDataMap, and reduces the number of vector copies at the callsites.
Finally, the CL splits the unittest for AutofillCountry according to splitting the production code. However, there has been no test specific to CountryDataMap only, so that class does not get a separate unittest.
BUG=571610
R=mathp@chromium.org
Review URL: https://codereview.chromium.org/1590923002
Cr-Commit-Position: refs/heads/master@{#370381}
Diffstat (limited to 'components/autofill.gypi')
| -rw-r--r-- | components/autofill.gypi | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/components/autofill.gypi b/components/autofill.gypi index f1dc69b..767f2d1 100644 --- a/components/autofill.gypi +++ b/components/autofill.gypi @@ -152,6 +152,10 @@ 'autofill/core/browser/card_unmask_delegate.h', 'autofill/core/browser/contact_info.cc', 'autofill/core/browser/contact_info.h', + 'autofill/core/browser/country_data.cc', + 'autofill/core/browser/country_data.h', + 'autofill/core/browser/country_names.cc', + 'autofill/core/browser/country_names.h', 'autofill/core/browser/credit_card.cc', 'autofill/core/browser/credit_card.h', 'autofill/core/browser/credit_card_field.cc', |