Rewrite std::string("") to std::string(), Linux edition.

This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.

BUG=none

Review URL: https://codereview.chromium.org/13145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 17 insertions, 14 deletions

diff --git a/components/autofill/browser/wallet/wallet_signin_helper_unittest.cc b/components/autofill/browser/wallet/wallet_signin_helper_unittest.cc
index e574d55..20175b1 100644
--- a/components/autofill/browser/wallet/wallet_signin_helper_unittest.cc
+++ b/components/autofill/browser/wallet/wallet_signin_helper_unittest.cc
@@ -120,9 +120,10 @@ class WalletSigninHelperTest : public testing::Test {
 
   void MockFailedOAuthLoginResponse404() {
     SetUpFetcherResponseAndCompleteRequest(
-        GaiaUrls::GetInstance()->client_login_url(), 404,
+        GaiaUrls::GetInstance()->client_login_url(),
+        404,
         net::ResponseCookies(),
-        "");
+        std::string());
   }
 
   void MockSuccessfulGaiaUserInfoResponse(const std::string& username) {
@@ -134,9 +135,10 @@ class WalletSigninHelperTest : public testing::Test {
 
   void MockFailedGaiaUserInfoResponse404() {
     SetUpFetcherResponseAndCompleteRequest(
-        GaiaUrls::GetInstance()->get_user_info_url(), 404,
+        GaiaUrls::GetInstance()->get_user_info_url(),
+        404,
         net::ResponseCookies(),
-        "");
+        std::string());
   }
 
   void MockSuccessfulGetAccountInfoResponse(const std::string& username) {
@@ -150,23 +152,24 @@ class WalletSigninHelperTest : public testing::Test {
 
   void MockFailedGetAccountInfoResponse404() {
     SetUpFetcherResponseAndCompleteRequest(
-        signin_helper_->GetGetAccountInfoUrlForTesting(), 404,
+        signin_helper_->GetGetAccountInfoUrlForTesting(),
+        404,
         net::ResponseCookies(),
-        "");
+        std::string());
   }
 
   void MockSuccessfulPassiveAuthUrlMergeAndRedirectResponse() {
-    SetUpFetcherResponseAndCompleteRequest(
-        wallet::GetPassiveAuthUrl().spec(), 200,
-        net::ResponseCookies(),
-        "");
+    SetUpFetcherResponseAndCompleteRequest(wallet::GetPassiveAuthUrl().spec(),
+                                           200,
+                                           net::ResponseCookies(),
+                                           std::string());
   }
 
   void MockFailedPassiveAuthUrlMergeAndRedirectResponse404() {
-    SetUpFetcherResponseAndCompleteRequest(
-        wallet::GetPassiveAuthUrl().spec(), 404,
-        net::ResponseCookies(),
-        "");
+    SetUpFetcherResponseAndCompleteRequest(wallet::GetPassiveAuthUrl().spec(),
+                                           404,
+                                           net::ResponseCookies(),
+                                           std::string());
   }
 
   WalletSigninHelperForTesting::State state() const {