Mac: Autofill should not immediately request access to address book.

If the browser does not yet have permission to access the user's contacts, one
of the Autofill suggestions has the text "Enable Autofill using Contacts". If
the user selects that suggestion, the browser will prompt the user for access
to the user's address book.

The act of clicking the permissions dialog causes Blink to lose its focus on
the text field, which also dismisses the Autofill popup. If the user has
granted Chrome access to the address book, the autofill popup will be presented
again, and filled in.

This CL does not include the image asset, nor does it include the logic to
display the image asset on the left of the autofill entry.

BUG=139154
TEST=Run the command `tccutil reset AddressBook` to reset AddressBook
permissions for all applications. Clear the default Chromium profile:
`rm -rf ~/Library/Application\ Support/Chromium/Default/`.  Launch Chromium by
double clicking on it from Finder.  Navigate to
`https://www.mycontactform.com/samples/change_address.php`. Double click the
"First Name" field. There should not be a prompt to access your "Contacts".
There should be exactly 1 autofill entry: "Enable Autofill using Contacts...".
Clicking that autofill entry should open a system prompt that asks for Contacts
permissions for Chromium.

Review URL: https://codereview.chromium.org/286243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274040 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 0 deletions

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h
index cb9fc6a..f9a99fe 100644
--- a/components/autofill/content/common/autofill_messages.h
+++ b/components/autofill/content/common/autofill_messages.h
@@ -94,6 +94,11 @@ IPC_ENUM_TRAITS_MAX_VALUE(
 
 // Autofill messages sent from the browser to the renderer.
 
+// Instructs the renderer to immediately return an IPC acknowledging the ping.
+// This is used to correctly sequence events, since IPCs are guaranteed to be
+// processed in order.
+IPC_MESSAGE_ROUTED0(AutofillMsg_Ping)
+
 // Instructs the renderer to fill the active form with the given form data.
 IPC_MESSAGE_ROUTED2(AutofillMsg_FillForm,
                     int /* query_id */,
@@ -227,6 +232,9 @@ IPC_MESSAGE_ROUTED5(AutofillHostMsg_QueryFormFieldAutofill,
 // Sent when a form is previewed with Autofill suggestions.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidPreviewAutofillFormData)
 
+// Sent immediately after the renderer receives a ping IPC.
+IPC_MESSAGE_ROUTED0(AutofillHostMsg_PingAck)
+
 // Sent when a form is filled with Autofill suggestions.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_DidFillAutofillFormData,
                     base::TimeTicks /* timestamp */)