diff options
| author | kareng <kareng@google.com> | 2014-11-02 20:15:39 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-03 04:16:02 +0000 |
| commit | 774088e62d9b28f15bc0f171d65a54cd1bf1c14a (patch) | |
| tree | 661993e54ea606d840ddded17e81f034e14e21a7 /components/autofill/content/common | |
| parent | 677ec3adaec076f5e41cee4f144459a77d677afc (diff) | |
| download | chromium_src-774088e62d9b28f15bc0f171d65a54cd1bf1c14a.zip chromium_src-774088e62d9b28f15bc0f171d65a54cd1bf1c14a.tar.gz chromium_src-774088e62d9b28f15bc0f171d65a54cd1bf1c14a.tar.bz2 | |
Revert of Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions (patchset #2 id:20001 of https://codereview.chromium.org/688633004/)
Reason for revert:
caused crashers. see bug 429576
Original issue's description:
> Do not haul suggestions back to browser in AutofillHostMsg_ShowPasswordSuggestions
>
> Currently, PasswordAutofillAgent (in renderer) prepares password autofill suggestions for PasswordAutofillManager (in browser) and sends them via IPC.
>
> But the manager has the data to generate the suggestions itself, so this CL makes it derive the suggestions from that data instead of hauling it through IPC.
>
> This CL also adds one more test case to the PasswordAutofillManager unittest, to compensate for the coverage lost in the PasswordAutofillAgent browsertest by moving some logic out of the agent to the manager.
>
> BUG=400186, 377422, 118601
>
> Committed: https://crrev.com/86cc798cc2947dd88aa73505d716f93538dffa5b
> Cr-Commit-Position: refs/heads/master@{#302245}
TBR=gcasto@chromium.org,tsepez@chromium.org,jww@chromium.org,vabr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=400186, 377422, 118601
Review URL: https://codereview.chromium.org/695233002
Cr-Commit-Position: refs/heads/master@{#302413}
Diffstat (limited to 'components/autofill/content/common')
| -rw-r--r-- | components/autofill/content/common/autofill_messages.h | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h index e339a64..25d8277 100644 --- a/components/autofill/content/common/autofill_messages.h +++ b/components/autofill/content/common/autofill_messages.h @@ -285,12 +285,13 @@ IPC_MESSAGE_ROUTED2(AutofillHostMsg_AddPasswordFormMapping, autofill::FormFieldData, /* the user name field */ autofill::PasswordFormFillData /* password pairings */) -// Instruct the browser to show a popup with suggestions for the form field. +// Instruct the browser to show a popup with the following suggestions from the +// password manager. IPC_MESSAGE_ROUTED4(AutofillHostMsg_ShowPasswordSuggestions, autofill::FormFieldData /* the form field */, - base::string16 /* username typed by user */, - bool /* show all suggestions */, - gfx::RectF /* input field bounds, window-relative */) + gfx::RectF /* input field bounds, window-relative */, + std::vector<base::string16> /* suggestions */, + std::vector<base::string16> /* realms */) // Inform browser of data list values for the curent field. IPC_MESSAGE_ROUTED2(AutofillHostMsg_SetDataList, |