diff options
| author | dvadym <dvadym@chromium.org> | 2016-02-23 03:55:27 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2016-02-23 11:56:58 +0000 |
| commit | c0a523a2e2d85e487c3aa32ad57ac1a3e4694d46 (patch) | |
| tree | 70a4f74a7a1a175891fdd98c777aa5e55d86d63c /components/autofill/content/common | |
| parent | d9c162ad0a240aa967c247f5be258056d6a4efbf (diff) | |
| download | chromium_src-c0a523a2e2d85e487c3aa32ad57ac1a3e4694d46.zip chromium_src-c0a523a2e2d85e487c3aa32ad57ac1a3e4694d46.tar.gz chromium_src-c0a523a2e2d85e487c3aa32ad57ac1a3e4694d46.tar.bz2 | |
Sending generated vote on password generation.
The generating of password by user is strong indication that the current form is suitable for generation and we can use it for improving our heuristics.
This patch adds |generation_event| to uploaded field vote (in AutofillField structure and in AutofillUploadContents proto) with information about generation event which happened.
BUG=552420
Review URL: https://codereview.chromium.org/1686063004
Cr-Commit-Position: refs/heads/master@{#376968}
Diffstat (limited to 'components/autofill/content/common')
| -rw-r--r-- | components/autofill/content/common/autofill_messages.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h index a3de142..8ddc5d8 100644 --- a/components/autofill/content/common/autofill_messages.h +++ b/components/autofill/content/common/autofill_messages.h @@ -193,7 +193,7 @@ IPC_MESSAGE_ROUTED0(AutofillMsg_FindFocusedPasswordForm) // Tells the renderer to find a focused element, and if it is a password field // eligible for generation then to trigger generation by responding to the // browser with the message |AutofillHostMsg_ShowPasswordGenerationPopup|. -IPC_MESSAGE_ROUTED0(AutofillMsg_GeneratePassword) +IPC_MESSAGE_ROUTED0(AutofillMsg_UserTriggeredGeneratePassword) // Tells the renderer that this password form is not blacklisted. A form can // be blacklisted if a user chooses "never save passwords for this site". @@ -322,9 +322,11 @@ IPC_MESSAGE_ROUTED1(AutofillHostMsg_GenerationAvailableForForm, // Instructs the browser to show the password generation popup at the // specified location. This location should be specified in the renderers // coordinate system. Form is the form associated with the password field. -IPC_MESSAGE_ROUTED3(AutofillHostMsg_ShowPasswordGenerationPopup, +IPC_MESSAGE_ROUTED5(AutofillHostMsg_ShowPasswordGenerationPopup, gfx::RectF /* source location */, int /* max length of the password */, + base::string16, /* password field */ + bool, /* is manually triggered */ autofill::PasswordForm) // Instructs the browser to show the popup for editing a generated password. |