summaryrefslogtreecommitdiffstats
path: root/components/autofill
diff options
context:
space:
mode:
authorestade <estade@chromium.org>2015-01-21 21:30:33 -0800
committerCommit bot <commit-bot@chromium.org>2015-01-22 05:31:27 +0000
commit5c598826de5e95c7f41b6e07f470d2962b8ed9cc (patch)
tree6726d754e9253acd5d943dd96183cf79c8e1f423 /components/autofill
parente8577e72d03cb144d954148da511ac9d929f537d (diff)
downloadchromium_src-5c598826de5e95c7f41b6e07f470d2962b8ed9cc.zip
chromium_src-5c598826de5e95c7f41b6e07f470d2962b8ed9cc.tar.gz
chromium_src-5c598826de5e95c7f41b6e07f470d2962b8ed9cc.tar.bz2
Autofill - don't respect autocomplete="off" for mac address book or
scan credit card suggestions. BUG=450680 Review URL: https://codereview.chromium.org/864873002 Cr-Commit-Position: refs/heads/master@{#312566}
Diffstat (limited to 'components/autofill')
-rw-r--r--components/autofill/core/browser/autofill_manager.cc2
-rw-r--r--components/autofill/core/browser/autofill_manager_unittest.cc2
2 files changed, 2 insertions, 2 deletions
diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc
index 18bd355..b9123d0 100644
--- a/components/autofill/core/browser/autofill_manager.cc
+++ b/components/autofill/core/browser/autofill_manager.cc
@@ -1108,7 +1108,7 @@ bool AutofillManager::GetCachedFormAndField(const FormData& form,
AutofillField* AutofillManager::GetAutofillField(const FormData& form,
const FormFieldData& field) {
- if (!personal_data_ || !field.should_autocomplete)
+ if (!personal_data_)
return NULL;
FormStructure* form_structure = NULL;
diff --git a/components/autofill/core/browser/autofill_manager_unittest.cc b/components/autofill/core/browser/autofill_manager_unittest.cc
index 246c26d..3bfc805 100644
--- a/components/autofill/core/browser/autofill_manager_unittest.cc
+++ b/components/autofill/core/browser/autofill_manager_unittest.cc
@@ -2826,7 +2826,7 @@ TEST_F(AutofillManagerTest, AccessAddressBookPrompt) {
autofill_manager_->ShouldShowAccessAddressBookSuggestion(form, field));
field.should_autocomplete = false;
- EXPECT_FALSE(
+ EXPECT_TRUE(
autofill_manager_->ShouldShowAccessAddressBookSuggestion(form, field));
}
#endif // defined(OS_MACOSX) && !defined(OS_IOS)