diff options
| author | esprehn <esprehn@chromium.org> | 2015-11-05 22:18:34 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-06 06:19:34 +0000 |
| commit | efbe739afee3dc961bb1fbcbf2b75627483e5f5b (patch) | |
| tree | 743e3b1b9073532f09fe3518ff8158c1330f3561 /components/autofill | |
| parent | 260ecd51b9f2090da212f3920f25809b945dd7d3 (diff) | |
| download | chromium_src-efbe739afee3dc961bb1fbcbf2b75627483e5f5b.zip chromium_src-efbe739afee3dc961bb1fbcbf2b75627483e5f5b.tar.gz chromium_src-efbe739afee3dc961bb1fbcbf2b75627483e5f5b.tar.bz2 | |
Remove WebNode::childNodes().
This is a bad API since it allocates multiple rare data objects on a
node or element. Instead users of WebNode should walk the firstChild
and nextSibling pointers which is cheaper and doesn't cause a permanent
memory increase.
Review URL: https://codereview.chromium.org/1405293011
Cr-Commit-Position: refs/heads/master@{#358270}
Diffstat (limited to 'components/autofill')
3 files changed, 0 insertions, 4 deletions
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc index 9c319d2..e6b456d 100644 --- a/components/autofill/content/renderer/form_autofill_util.cc +++ b/components/autofill/content/renderer/form_autofill_util.cc @@ -30,7 +30,6 @@ #include "third_party/WebKit/public/web/WebLabelElement.h" #include "third_party/WebKit/public/web/WebLocalFrame.h" #include "third_party/WebKit/public/web/WebNode.h" -#include "third_party/WebKit/public/web/WebNodeList.h" #include "third_party/WebKit/public/web/WebOptionElement.h" #include "third_party/WebKit/public/web/WebSelectElement.h" #include "third_party/WebKit/public/web/WebTextAreaElement.h" @@ -44,7 +43,6 @@ using blink::WebFrame; using blink::WebInputElement; using blink::WebLabelElement; using blink::WebNode; -using blink::WebNodeList; using blink::WebOptionElement; using blink::WebSelectElement; using blink::WebTextAreaElement; diff --git a/components/autofill/content/renderer/form_cache.cc b/components/autofill/content/renderer/form_cache.cc index 81ddf83..2650b43 100644 --- a/components/autofill/content/renderer/form_cache.cc +++ b/components/autofill/content/renderer/form_cache.cc @@ -19,7 +19,6 @@ #include "third_party/WebKit/public/web/WebFormElement.h" #include "third_party/WebKit/public/web/WebInputElement.h" #include "third_party/WebKit/public/web/WebLocalFrame.h" -#include "third_party/WebKit/public/web/WebNodeList.h" #include "third_party/WebKit/public/web/WebSelectElement.h" #include "third_party/WebKit/public/web/WebTextAreaElement.h" #include "ui/base/l10n/l10n_util.h" diff --git a/components/autofill/content/renderer/password_autofill_agent.cc b/components/autofill/content/renderer/password_autofill_agent.cc index f1c7869..69b27bc 100644 --- a/components/autofill/content/renderer/password_autofill_agent.cc +++ b/components/autofill/content/renderer/password_autofill_agent.cc @@ -34,7 +34,6 @@ #include "third_party/WebKit/public/web/WebInputEvent.h" #include "third_party/WebKit/public/web/WebLocalFrame.h" #include "third_party/WebKit/public/web/WebNode.h" -#include "third_party/WebKit/public/web/WebNodeList.h" #include "third_party/WebKit/public/web/WebSecurityOrigin.h" #include "third_party/WebKit/public/web/WebUserGestureIndicator.h" #include "third_party/WebKit/public/web/WebView.h" |