diff options
| author | fdoray <fdoray@chromium.org> | 2015-11-05 23:18:00 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-06 07:19:55 +0000 |
| commit | 717f84522681c0810ff444619b40d1bcdabb0079 (patch) | |
| tree | 402e4e548bfb9aa41a42007fccff2df1d9e15557 /components/bookmarks | |
| parent | 65190c52d76c75993fc6c19c944ca1891a8dca0a (diff) | |
| download | chromium_src-717f84522681c0810ff444619b40d1bcdabb0079.zip chromium_src-717f84522681c0810ff444619b40d1bcdabb0079.tar.gz chromium_src-717f84522681c0810ff444619b40d1bcdabb0079.tar.bz2 | |
Revert of Move components/startup_metric_utils/* to components/startup_metric_utils/browser/*. (patchset #5 id:80001 of https://codereview.chromium.org/1413153010/ )
Reason for revert:
We suspect that this CL is responsible for a 7.1%-7.7% regression in startup.warm.blank_page (crbug.com/551690)
Original issue's description:
> Move components/startup_metric_utils/* to components/startup_metric_utils/browser/*.
>
> We are working on new startup metrics that require sending IPCs from
> the renderer to the browser. The message definitions will live in
> components/startup_metric_utils/common/*, while the code that receives
> IPCs and logs UMA metrics will live in
> components/startup_metric_utils/browser/*.
>
> As a first step towards implementing these new metrics, this CL moves
> existing code from components/startup_metric_utils/* to
> components/startup_metric_utils/browser/*.
>
> BUG=547794
>
> Committed: https://crrev.com/055d3862641a91e4a5ff2a49bd5d0f835f0436d1
> Cr-Commit-Position: refs/heads/master@{#357702}
TBR=gab@chromium.org,sky@chromium.org,caitkp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=551690
Review URL: https://codereview.chromium.org/1431053003
Cr-Commit-Position: refs/heads/master@{#358278}
Diffstat (limited to 'components/bookmarks')
| -rw-r--r-- | components/bookmarks/DEPS | 1 | ||||
| -rw-r--r-- | components/bookmarks/browser/BUILD.gn | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/components/bookmarks/DEPS b/components/bookmarks/DEPS index 1871065..75997b1 100644 --- a/components/bookmarks/DEPS +++ b/components/bookmarks/DEPS @@ -3,6 +3,7 @@ include_rules = [ "+components/keyed_service", "+components/pref_registry", "+components/query_parser", + "+components/startup_metric_utils", "+components/url_formatter", "+grit/components_strings.h", "+jni", diff --git a/components/bookmarks/browser/BUILD.gn b/components/bookmarks/browser/BUILD.gn index c0ec3b2..97f5065 100644 --- a/components/bookmarks/browser/BUILD.gn +++ b/components/bookmarks/browser/BUILD.gn @@ -50,6 +50,7 @@ source_set("browser") { "//components/keyed_service/core", "//components/pref_registry", "//components/query_parser", + "//components/startup_metric_utils", "//components/strings", "//components/url_formatter", "//net", |