Add utilities to remove duplication in BookmarkClient implementations.

Add utility free functions to //components/bookmarks/managed and
//components/favicon/core to share common code between both
BookmarkClient implementations (desktop and iOS).

BUG=514208

Review URL: https://codereview.chromium.org/1262123002

Cr-Commit-Position: refs/heads/master@{#340912}

3 files changed, 58 insertions, 0 deletions

diff --git a/components/bookmarks/managed/BUILD.gn b/components/bookmarks/managed/BUILD.gn
index 441ee67..ed8d2a6 100644
--- a/components/bookmarks/managed/BUILD.gn
+++ b/components/bookmarks/managed/BUILD.gn
@@ -6,6 +6,8 @@ source_set("managed") {
   sources = [
     "managed_bookmark_service.cc",
     "managed_bookmark_service.h",
+    "managed_bookmark_util.cc",
+    "managed_bookmark_util.h",
     "managed_bookmarks_tracker.cc",
     "managed_bookmarks_tracker.h",
   ]
diff --git a/components/bookmarks/managed/managed_bookmark_util.cc b/components/bookmarks/managed/managed_bookmark_util.cc
new file mode 100644
index 0000000..d19d941
--- /dev/null
+++ b/components/bookmarks/managed/managed_bookmark_util.cc
@@ -0,0 +1,33 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/bookmarks/managed/managed_bookmark_util.h"
+
+#include "components/bookmarks/browser/bookmark_node.h"
+#include "components/bookmarks/managed/managed_bookmark_service.h"
+
+namespace bookmarks {
+
+bool IsPermanentNode(const BookmarkPermanentNode* node,
+                     ManagedBookmarkService* managed_bookmark_service) {
+  BookmarkNode::Type type = node->type();
+  if (type == BookmarkNode::BOOKMARK_BAR ||
+      type == BookmarkNode::OTHER_NODE ||
+      type == BookmarkNode::MOBILE) {
+    return true;
+  }
+
+  return IsManagedNode(node, managed_bookmark_service);
+}
+
+bool IsManagedNode(const BookmarkPermanentNode* node,
+                   ManagedBookmarkService* managed_bookmark_service) {
+  if (!managed_bookmark_service)
+    return false;
+
+  return node == managed_bookmark_service->managed_node() ||
+         node == managed_bookmark_service->supervised_node();
+}
+
+}  // namespace bookmarks
diff --git a/components/bookmarks/managed/managed_bookmark_util.h b/components/bookmarks/managed/managed_bookmark_util.h
new file mode 100644
index 0000000..9b3ec181
--- /dev/null
+++ b/components/bookmarks/managed/managed_bookmark_util.h
@@ -0,0 +1,23 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_BOOKMARKS_MANAGED_MANAGED_BOOKMARK_UTIL_H_
+#define COMPONENTS_BOOKMARKS_MANAGED_MANAGED_BOOKMARK_UTIL_H_
+
+namespace bookmarks {
+
+class BookmarkPermanentNode;
+class ManagedBookmarkService;
+
+// Returns whether |node| is a permanent node.
+bool IsPermanentNode(const BookmarkPermanentNode* node,
+                     ManagedBookmarkService* managed_bookmark_service);
+
+// Returns whether |node| is a managed node.
+bool IsManagedNode(const BookmarkPermanentNode* node,
+                   ManagedBookmarkService* managed_bookmark_service);
+
+}  // namespace bookmarks
+
+#endif  // COMPONENTS_BOOKMARKS_MANAGED_MANAGED_BOOKMARK_UTIL_H_