diff options
| author | vadimt <vadimt@chromium.org> | 2014-11-04 08:53:11 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-11-04 16:53:37 +0000 |
| commit | c17c4cf24972a763a82230383fd40bd29620bab3 (patch) | |
| tree | cb2547e44329a9567d1ccb418f0818e1d6fbb581 /components/captive_portal | |
| parent | 16d4cbbb67e198ebad8ccb774e5ab53e6dc84303 (diff) | |
| download | chromium_src-c17c4cf24972a763a82230383fd40bd29620bab3.zip chromium_src-c17c4cf24972a763a82230383fd40bd29620bab3.tar.gz chromium_src-c17c4cf24972a763a82230383fd40bd29620bab3.tar.bz2 | |
Removing instrumentations for task URLFetcherCore::OnCompletedURLRequest
The jank almost disappeared, either because it was fixed, or its numbers were absorbed by other instrumentations.
At the current moment in Win, instrumentation for OAuth2AccessTokenFetcherImpl::OnURLFetchComplete shown 1.65 118ms jph, and remaining own jankiness of URLFetcherCore::OnCompletedURLRequest is 2.87.
BUG=422577
TBR=toyoshim@chromium.org, dconnelly@chromium.org, pkasting@chromium.org, zea@chromium.org, yoz@chromium.org, mmenke@chromium.org, dcheng@chromium.org, mattm@chromium.org, jhawkins@chromium.org, rogerta@chromium.org
Review URL: https://codereview.chromium.org/701463004
Cr-Commit-Position: refs/heads/master@{#302620}
Diffstat (limited to 'components/captive_portal')
| -rw-r--r-- | components/captive_portal/captive_portal_detector.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/components/captive_portal/captive_portal_detector.cc b/components/captive_portal/captive_portal_detector.cc index 397393f..912b7e4 100644 --- a/components/captive_portal/captive_portal_detector.cc +++ b/components/captive_portal/captive_portal_detector.cc @@ -5,7 +5,6 @@ #include "components/captive_portal/captive_portal_detector.h" #include "base/logging.h" -#include "base/profiler/scoped_tracker.h" #include "base/strings/string_number_conversions.h" #include "net/base/load_flags.h" #include "net/http/http_response_headers.h" @@ -58,11 +57,6 @@ void CaptivePortalDetector::Cancel() { } void CaptivePortalDetector::OnURLFetchComplete(const net::URLFetcher* source) { - // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed. - tracked_objects::ScopedTracker tracking_profile( - FROM_HERE_WITH_EXPLICIT_FUNCTION( - "422577 CaptivePortalDetector::OnURLFetchComplete")); - DCHECK(CalledOnValidThread()); DCHECK(FetchingURL()); DCHECK_EQ(url_fetcher_.get(), source); |