summaryrefslogtreecommitdiffstats
path: root/components/clipboard/BUILD.gn
diff options
context:
space:
mode:
authorjam <jam@chromium.org>2015-05-26 15:44:09 -0700
committerCommit bot <commit-bot@chromium.org>2015-05-26 22:45:46 +0000
commit1233b850c820b957ba5cb009bcc64155f6d35247 (patch)
treea0bf8bc46cb74458dc30d5ac9717c53f78c86fe7 /components/clipboard/BUILD.gn
parentb051a19b8ef33e67b580fcd7b13b9175f286bf9b (diff)
downloadchromium_src-1233b850c820b957ba5cb009bcc64155f6d35247.zip
chromium_src-1233b850c820b957ba5cb009bcc64155f6d35247.tar.gz
chromium_src-1233b850c820b957ba5cb009bcc64155f6d35247.tar.bz2
Add missing mojo dependencies that were causing mojo_apptest hangs.
I logged into one failing machine and ran "mojo_runner --use-headless-config --gtest_filter=ViewManagerTest.RootView mojo:view_manager_apptests". The test printed that it passed but then hung. The output had "[0525/201523:ERROR:default_logger_impl.cc(46)] validation_errors.cc(61): Invalid message: VALIDATION_ERROR_UNEXPECTED_STRUCT_HEADER". This is because a component had a different version of the mojom serialization. Tracking down the build dependencies, it was because view_manager didn't depend on surfaces, and also mandoline:tests needed to depend on view_manager:apptests. I verified that building mandoline:tests on a broken bot fixed this. I looked through all the apptests to make sure there were no other missing dependencies. I also removed an unnecessary "$default_toolchain)" in clipboard's build file. BUG=478244 Review URL: https://codereview.chromium.org/1154153002 Cr-Commit-Position: refs/heads/master@{#331465}
Diffstat (limited to 'components/clipboard/BUILD.gn')
-rw-r--r--components/clipboard/BUILD.gn2
1 files changed, 1 insertions, 1 deletions
diff --git a/components/clipboard/BUILD.gn b/components/clipboard/BUILD.gn
index 4a351a7..336db09 100644
--- a/components/clipboard/BUILD.gn
+++ b/components/clipboard/BUILD.gn
@@ -47,5 +47,5 @@ mojo_native_application("apptests") {
"//mojo/application/public/cpp:test_support",
]
- data_deps = [ ":clipboard($default_toolchain)" ]
+ data_deps = [ ":clipboard" ]
}