diff options
author | xhwang <xhwang@chromium.org> | 2014-10-02 19:40:30 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-10-03 02:40:44 +0000 |
commit | 0d1882c21c2296a90ce259ef5e732662f946226b (patch) | |
tree | 83abf890c6b09d21509000193a1850caae60560c /components/component_updater/default_component_installer.h | |
parent | 5aa22b960e030b7064afe5fd93f033a1ce321c57 (diff) | |
download | chromium_src-0d1882c21c2296a90ce259ef5e732662f946226b.zip chromium_src-0d1882c21c2296a90ce259ef5e732662f946226b.tar.gz chromium_src-0d1882c21c2296a90ce259ef5e732662f946226b.tar.bz2 |
Component Installer: Check manifest in VerifyInstallation().
Details:
- Check manifest in VerifyInstallation().
- Only check VerifyInstallation() for the latest folder found. Since we are only
trying to catch abnormal cases, this should be fine.
BUG=419582
Review URL: https://codereview.chromium.org/604373007
Cr-Commit-Position: refs/heads/master@{#297975}
Diffstat (limited to 'components/component_updater/default_component_installer.h')
-rw-r--r-- | components/component_updater/default_component_installer.h | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/components/component_updater/default_component_installer.h b/components/component_updater/default_component_installer.h index 83c2a5f..6eaaecd 100644 --- a/components/component_updater/default_component_installer.h +++ b/components/component_updater/default_component_installer.h @@ -35,11 +35,13 @@ class ComponentInstallerTraits { virtual ~ComponentInstallerTraits(); // Verifies that a working installation resides within the directory specified - // by |dir|. |dir| is of the form <base directory>/<version>. + // by |install_dir|. |install_dir| is of the form <base directory>/<version>. + // |manifest| should have been read from the manifest file in |install_dir|. // Called only from a thread belonging to a blocking thread pool. // The implementation of this function must be efficient since the function // can be called when Chrome starts. - virtual bool VerifyInstallation(const base::FilePath& dir) const = 0; + virtual bool VerifyInstallation(const base::DictionaryValue& manifest, + const base::FilePath& install_dir) const = 0; // Returns true if the component can be automatically updated. Called once // during component registration from the UI thread. |