diff options
| author | bauerb <bauerb@chromium.org> | 2015-02-04 17:09:10 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-02-05 01:09:55 +0000 |
| commit | 810e60f487982e8edc208b78b0b4b2b2a12a77a0 (patch) | |
| tree | f76a8cb2498a8e32804fd0a9eb04703ed7a84127 /components/component_updater/default_component_installer.h | |
| parent | abfbde8049ea4726e3c750a15aad66c5ab9f5093 (diff) | |
| download | chromium_src-810e60f487982e8edc208b78b0b4b2b2a12a77a0.zip chromium_src-810e60f487982e8edc208b78b0b4b2b2a12a77a0.tar.gz chromium_src-810e60f487982e8edc208b78b0b4b2b2a12a77a0.tar.bz2 | |
Make ComponentInstaller refcounted.
Before this CL, component installers were leaked in almost all cases. If we allow uninstalling components (see https://codereview.chromium.org/879993005/), we need to fix those leaks.
BUG=436459
Review URL: https://codereview.chromium.org/897873002
Cr-Commit-Position: refs/heads/master@{#314701}
Diffstat (limited to 'components/component_updater/default_component_installer.h')
| -rw-r--r-- | components/component_updater/default_component_installer.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/components/component_updater/default_component_installer.h b/components/component_updater/default_component_installer.h index 120d3a5..8a39993 100644 --- a/components/component_updater/default_component_installer.h +++ b/components/component_updater/default_component_installer.h @@ -99,15 +99,16 @@ class DefaultComponentInstaller : public update_client::ComponentInstaller { bool GetInstalledFile(const std::string& file, base::FilePath* installed_file) override; + private: ~DefaultComponentInstaller() override; - private: base::FilePath GetInstallDirectory(); bool InstallHelper(const base::DictionaryValue& manifest, const base::FilePath& unpack_path, const base::FilePath& install_path); void StartRegistration(ComponentUpdateService* cus); void FinishRegistration(ComponentUpdateService* cus); + void ComponentReady(scoped_ptr<base::DictionaryValue> manifest); base::Version current_version_; std::string current_fingerprint_; |