diff options
| author | cmumford <cmumford@chromium.org> | 2015-08-07 11:08:58 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-07 18:09:30 +0000 |
| commit | c7a9315c7376b3d4664b03c57bcc295b11e46767 (patch) | |
| tree | 670e479f1cc35e72d02384d7ad2d6e74ad9ad661 /components/component_updater | |
| parent | a69cf2d9c0368c084d259375e11fe3f114bbb317 (diff) | |
| download | chromium_src-c7a9315c7376b3d4664b03c57bcc295b11e46767.zip chromium_src-c7a9315c7376b3d4664b03c57bcc295b11e46767.tar.gz chromium_src-c7a9315c7376b3d4664b03c57bcc295b11e46767.tar.bz2 | |
Avoiding creation of new string for component version.
base::Version constructor already takes a std::string, so no need to
pass in result of c_str() which would just create a second std::string.
Review URL: https://codereview.chromium.org/1280673002
Cr-Commit-Position: refs/heads/master@{#342383}
Diffstat (limited to 'components/component_updater')
| -rw-r--r-- | components/component_updater/default_component_installer.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/component_updater/default_component_installer.cc b/components/component_updater/default_component_installer.cc index e4eb99c..b757c0d 100644 --- a/components/component_updater/default_component_installer.cc +++ b/components/component_updater/default_component_installer.cc @@ -84,7 +84,7 @@ bool DefaultComponentInstaller::Install(const base::DictionaryValue& manifest, const base::FilePath& unpack_path) { std::string manifest_version; manifest.GetStringASCII("version", &manifest_version); - base::Version version(manifest_version.c_str()); + base::Version version(manifest_version); if (!version.IsValid()) return false; if (current_version_.CompareTo(version) > 0) |