diff options
| author | brettw <brettw@chromium.org> | 2015-07-23 16:23:31 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-07-23 23:25:00 +0000 |
| commit | 8be197d144c267c6a7c1b207a41267ac6c971712 (patch) | |
| tree | 22d99a93dc2f060d8637abbea5fcc869cc602686 /components/content_settings | |
| parent | a36acb95c375d4de17277cadbe8d56b45a80d5ce (diff) | |
| download | chromium_src-8be197d144c267c6a7c1b207a41267ac6c971712.zip chromium_src-8be197d144c267c6a7c1b207a41267ac6c971712.tar.gz chromium_src-8be197d144c267c6a7c1b207a41267ac6c971712.tar.bz2 | |
Update SplitString calls in components
This converts calls from the old form to the new form. Some calls that iterated over the results were changed to a range-based for loop with an inline call to SplitString. Some places were changed to use StringPieces when it was safe to do so.
Review URL: https://codereview.chromium.org/1234973004
Cr-Commit-Position: refs/heads/master@{#340209}
Diffstat (limited to 'components/content_settings')
| -rw-r--r-- | components/content_settings/core/browser/content_settings_utils.cc | 5 | ||||
| -rw-r--r-- | components/content_settings/core/common/content_settings_pattern.cc | 11 |
2 files changed, 8 insertions, 8 deletions
diff --git a/components/content_settings/core/browser/content_settings_utils.cc b/components/content_settings/core/browser/content_settings_utils.cc index eb91f0b..5c48e9b 100644 --- a/components/content_settings/core/browser/content_settings_utils.cc +++ b/components/content_settings/core/browser/content_settings_utils.cc @@ -112,8 +112,9 @@ std::string CreatePatternString( } PatternPair ParsePatternString(const std::string& pattern_str) { - std::vector<std::string> pattern_str_list; - base::SplitString(pattern_str, kPatternSeparator[0], &pattern_str_list); + std::vector<std::string> pattern_str_list = base::SplitString( + pattern_str, std::string(1, kPatternSeparator[0]), + base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); // If the |pattern_str| is an empty string then the |pattern_string_list| // contains a single empty string. In this case the empty string will be diff --git a/components/content_settings/core/common/content_settings_pattern.cc b/components/content_settings/core/common/content_settings_pattern.cc index b02cbee..634e487 100644 --- a/components/content_settings/core/common/content_settings_pattern.cc +++ b/components/content_settings/core/common/content_settings_pattern.cc @@ -47,17 +47,16 @@ bool IsSubDomainOrEqual(const std::string& sub_domain, // Compares two domain names. int CompareDomainNames(const std::string& str1, const std::string& str2) { - std::vector<std::string> domain_name1; - std::vector<std::string> domain_name2; - - base::SplitString(str1, '.', &domain_name1); - base::SplitString(str2, '.', &domain_name2); + std::vector<base::StringPiece> domain_name1 = base::SplitStringPiece( + str1, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); + std::vector<base::StringPiece> domain_name2 = base::SplitStringPiece( + str2, ".", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); int i1 = static_cast<int>(domain_name1.size()) - 1; int i2 = static_cast<int>(domain_name2.size()) - 1; int rv; while (i1 >= 0 && i2 >= 0) { - // domain names are stored in puny code. So it's fine to use the compare + // Domain names are stored in puny code. So it's fine to use the compare // method. rv = domain_name1[i1].compare(domain_name2[i2]); if (rv != 0) |