diff options
| author | pavely <pavely@chromium.org> | 2015-03-10 18:18:51 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-03-11 01:20:02 +0000 |
| commit | be7169cf3591e428d0b4056a2c23c8ace14f6169 (patch) | |
| tree | bbf117b5a420dad356ed489612ce0ef446174623 /components/dom_distiller | |
| parent | 26b51a09bfdd04ad4e11b99d7acf9446aa98e752 (diff) | |
| download | chromium_src-be7169cf3591e428d0b4056a2c23c8ace14f6169.zip chromium_src-be7169cf3591e428d0b4056a2c23c8ace14f6169.tar.gz chromium_src-be7169cf3591e428d0b4056a2c23c8ace14f6169.tar.bz2 | |
[Sync] Refactor AttachmentStore classes. Introduce concept of referrer.
In this change:
- Move towards following class hierarchy: http://www.plantuml.com:80/plantuml/png/ZPBTJiCm38NlynIvv4TzWsaI525nCI5jkw-on1EZQHmvwQG9U7TC4-ZeKiITvNm-EiSExbv1Hxc6VOszYs24mDHQeG6xFNcGRqBAknYLVkd0nKr40l7nmqrU1deDeRUHYrfPkrEw3LmJx848YCkWqODfkECZBIOAZuHin9abWxUo9b0Hdjt38RGJyEhwZ4YZI9kJq_mmRp0pAPKnd7pGgG8t6usTHyVe7_FPtY3mbOth9ghGDjGxTnwlaEq-ySjv-KmCwZflxvVyE5bSIa4Mw7ZGyDHvAyHurPkgkhZgz9PuoNp75tDhAUZcJ68cwkATHyfXnFWn4_PFDsKuNLuKLrFodGS-0G00
- Remove AttachmenService::GetStore. Now attachment store is owned by
model type, there is no need to get it from AttachmentService
- Introduce AttachmentReferrer. There is no functionality behind it yet
and interface is not complete for it. These will come in the next change.
BUG=457735
R=maniscalco@chromium.org
TEST=Not exposed in chrome. Only unit tests available (sync_unit_tests)
Committed: https://crrev.com/6adcada8a799057c31c0f17550c9e2747a8df847
Cr-Commit-Position: refs/heads/master@{#319733}
Review URL: https://codereview.chromium.org/986743004
Cr-Commit-Position: refs/heads/master@{#320015}
Diffstat (limited to 'components/dom_distiller')
| -rw-r--r-- | components/dom_distiller/core/dom_distiller_store.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/components/dom_distiller/core/dom_distiller_store.h b/components/dom_distiller/core/dom_distiller_store.h index 103d43e..2440ce5 100644 --- a/components/dom_distiller/core/dom_distiller_store.h +++ b/components/dom_distiller/core/dom_distiller_store.h @@ -199,7 +199,7 @@ class DomDistillerStore : public syncer::SyncableService, scoped_ptr<syncer::SyncErrorFactory> error_factory_; scoped_ptr<leveldb_proto::ProtoDatabase<ArticleEntry> > database_; bool database_loaded_; - scoped_refptr<syncer::AttachmentStore> attachment_store_; + scoped_ptr<syncer::AttachmentStore> attachment_store_; ObserverList<DomDistillerObserver> observers_; DomDistillerModel model_; |