diff options
| author | kkimlabs <kkimlabs@chromium.org> | 2015-04-03 03:08:09 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-04-03 10:08:37 +0000 |
| commit | 16a0d2a22d17e3932432dab4559e63c5134aaccc (patch) | |
| tree | cb3602e115c8dc531195283d2c417825005f00ad /components/enhanced_bookmarks/BUILD.gn | |
| parent | a4c00a7ec01b3308c98cfad88b4bf3af1b4fde2b (diff) | |
| download | chromium_src-16a0d2a22d17e3932432dab4559e63c5134aaccc.zip chromium_src-16a0d2a22d17e3932432dab4559e63c5134aaccc.tar.gz chromium_src-16a0d2a22d17e3932432dab4559e63c5134aaccc.tar.bz2 | |
Fix crashes due to gfx::Image unsafe thread passing
gfx::Image has |storage_| member which is base::RefCounted, not thread
safe. Thus passing around gfx::Image to other threads by copying is
incorrect.
Workaround by using scoped_ptr and making ImageRecord class
RefCountedThreadSafe.
Related discussion:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/8LqVoXQ_2bo
BUG=471800
Review URL: https://codereview.chromium.org/1031293002
Cr-Commit-Position: refs/heads/master@{#323720}
Diffstat (limited to 'components/enhanced_bookmarks/BUILD.gn')
| -rw-r--r-- | components/enhanced_bookmarks/BUILD.gn | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/components/enhanced_bookmarks/BUILD.gn b/components/enhanced_bookmarks/BUILD.gn index 924b570..be2322b 100644 --- a/components/enhanced_bookmarks/BUILD.gn +++ b/components/enhanced_bookmarks/BUILD.gn @@ -23,6 +23,7 @@ source_set("enhanced_bookmarks") { "enhanced_bookmark_model_observer.h", "enhanced_bookmark_utils.cc", "enhanced_bookmark_utils.h", + "image_record.cc", "image_record.h", "image_store.cc", "image_store.h", |