diff options
author | rfevang <rfevang@chromium.org> | 2015-02-05 14:24:13 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-02-05 22:25:21 +0000 |
commit | 846191e5a12945951960c39b43ec33ee5d35cfba (patch) | |
tree | fcc3da6e3f662f7122eaede10ddd7533fbf45d62 /components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc | |
parent | 62ae3a5d1154960a8f01c0b7e2a3c6f609c4767f (diff) | |
download | chromium_src-846191e5a12945951960c39b43ec33ee5d35cfba.zip chromium_src-846191e5a12945951960c39b43ec33ee5d35cfba.tar.gz chromium_src-846191e5a12945951960c39b43ec33ee5d35cfba.tar.bz2 |
Dont set NEEDS_OFFLINE_PROCESSING flag.
The server will now always do processing for nodes that don't have
stars.id set, so no need to flip this flag any more.
BUG=
Review URL: https://codereview.chromium.org/888983002
Cr-Commit-Position: refs/heads/master@{#314900}
Diffstat (limited to 'components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc')
-rw-r--r-- | components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc | 79 |
1 files changed, 0 insertions, 79 deletions
diff --git a/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc b/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc index 3f4517b..4b53abd 100644 --- a/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc +++ b/components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc @@ -679,85 +679,6 @@ TEST_F(EnhancedBookmarkModelTest, NodeRemovedWhileResetDuplicationScheduled) { base::RunLoop().RunUntilIdle(); } -// Verifies that the NEEDS_OFFLINE_PROCESSING flag is set for nodes added -// with no remote id. -TEST_F(EnhancedBookmarkModelTest, BookmarkAddedSetsOfflineProcessingFlag) { - const BookmarkNode* node = - bookmark_model_->AddURL(bookmark_model_->other_node(), - 0, - base::ASCIIToUTF16("Some title"), - GURL(BOOKMARK_URL)); - std::string flags_str; - EXPECT_FALSE(node->GetMetaInfo("stars.flags", &flags_str)); - base::RunLoop().RunUntilIdle(); - ASSERT_TRUE(node->GetMetaInfo("stars.flags", &flags_str)); - int flags; - ASSERT_TRUE(base::StringToInt(flags_str, &flags)); - EXPECT_EQ(1, (flags & 1)); -} - -// Verifies that the NEEDS_OFFLINE_PROCESSING_FLAG is not set for added folders. -TEST_F(EnhancedBookmarkModelTest, FolderAddedDoesNotSetOfflineProcessingFlag) { - const BookmarkNode* node = AddFolder(); - base::RunLoop().RunUntilIdle(); - - std::string flags_str; - if (node->GetMetaInfo("stars.flags", &flags_str)) { - int flags; - ASSERT_TRUE(base::StringToInt(flags_str, &flags)); - EXPECT_EQ(0, (flags & 1)); - } -} - -// Verifies that when a bookmark is added that has a remote id, the status of -// the NEEDS_OFFLINE_PROCESSING flag doesn't change. -TEST_F(EnhancedBookmarkModelTest, - BookmarkAddedWithIdKeepsOfflineProcessingFlag) { - BookmarkNode::MetaInfoMap meta_info; - meta_info["stars.id"] = "some_id"; - meta_info["stars.flags"] = "1"; - - const BookmarkNode* node1 = - bookmark_model_->AddURLWithCreationTimeAndMetaInfo( - bookmark_model_->other_node(), - 0, - base::ASCIIToUTF16("Some title"), - GURL(BOOKMARK_URL), - base::Time::Now(), - &meta_info); - base::RunLoop().RunUntilIdle(); - std::string flags_str; - ASSERT_TRUE(node1->GetMetaInfo("stars.flags", &flags_str)); - int flags; - ASSERT_TRUE(base::StringToInt(flags_str, &flags)); - EXPECT_EQ(1, (flags & 1)); - - meta_info["stars.flags"] = "0"; - const BookmarkNode* node2 = - bookmark_model_->AddURLWithCreationTimeAndMetaInfo( - bookmark_model_->other_node(), - 0, - base::ASCIIToUTF16("Some title"), - GURL(BOOKMARK_URL), - base::Time::Now(), - &meta_info); - base::RunLoop().RunUntilIdle(); - ASSERT_TRUE(node2->GetMetaInfo("stars.flags", &flags_str)); - ASSERT_TRUE(base::StringToInt(flags_str, &flags)); - EXPECT_EQ(0, (flags & 1)); -} - -TEST_F(EnhancedBookmarkModelTest, - NodeRemovedWhileSetNeedsOfflineProcessingIsScheduled) { - const BookmarkNode* node = - bookmark_model_->AddURL(bookmark_model_->other_node(), - 0, - base::ASCIIToUTF16("Some title"), - GURL(BOOKMARK_URL)); - bookmark_model_->Remove(node->parent(), node->parent()->GetIndexOf(node)); - base::RunLoop().RunUntilIdle(); -} - TEST_F(EnhancedBookmarkModelTest, RemoveParentShouldRemoveChildrenFromMaps) { const BookmarkNode* parent = AddFolder(); |