diff options
| author | simonb <simonb@chromium.org> | 2014-10-06 07:36:01 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-10-06 14:36:16 +0000 |
| commit | 4749549c06525071692f777fc6a1fa5a9ad7f877 (patch) | |
| tree | b7f85a8b65dc33d69f48ded25354b07896b999f7 /components/favicon_base | |
| parent | a5d32a2fac874ad135c75361dff17fa00813c76e (diff) | |
| download | chromium_src-4749549c06525071692f777fc6a1fa5a9ad7f877.zip chromium_src-4749549c06525071692f777fc6a1fa5a9ad7f877.tar.gz chromium_src-4749549c06525071692f777fc6a1fa5a9ad7f877.tar.bz2 | |
Move version branding to before relocation packing.
Objcopy knows nothing about the dynamic tags that point to packed
relocation data. If objcopy is run after relocation packing, and if it
moves the .android.rel.dyn section, these dynamic tags become invalid
and the crazy linker cannot load the library:
E/chromium_android_linker( 9584): Open:
Could not open libchrome.2180.0.so:
Bad packed relocations ident, expected APR1 or APA1
Currently, version branding happens at the end of building libchrome.so,
and after relocation packing. Re-order so that relocation packing again
comes after all other strip and/or objcopy operations.
BUG=417510
Review URL: https://codereview.chromium.org/621263003
Cr-Commit-Position: refs/heads/master@{#298236}
Diffstat (limited to 'components/favicon_base')
0 files changed, 0 insertions, 0 deletions