diff options
author | thakis <thakis@chromium.org> | 2015-05-26 16:19:46 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-05-26 23:20:13 +0000 |
commit | 45ab39af3cc293e150158bf06515a47319db9f79 (patch) | |
tree | 3f91fca34ba161e8067d37f0271a5f1e07bcd794 /components/gcm_driver/gcm_client_impl_unittest.cc | |
parent | 500c73447f279b2afcd79b00c1060e0bde1ee849 (diff) | |
download | chromium_src-45ab39af3cc293e150158bf06515a47319db9f79.zip chromium_src-45ab39af3cc293e150158bf06515a47319db9f79.tar.gz chromium_src-45ab39af3cc293e150158bf06515a47319db9f79.tar.bz2 |
Use --icf=all instead of --icf=safe
With --icf=safe, functions whose address is taken aren't folded.
Folding could change the results of function pointer comparisons.
However, on x86_64 with pie, --icf=safe disables almost all folding,
for technical reasons. Since using --icf=all will save 7 MB on x86_64
and all tests seem to pass with it, switch to --icf=all. If we end up
having a function where we absolutely need equality, we can pass
--keep-unique,<symbol-name> for that symbol.
And if this turns out to be some maintenance burden, we can switch
back to --icf=safe.
Change the flag on all platforms where we use gold, not just x86_64, for
consistency so that if we end up having problems with this, we notice
it faster.
BUG=76280,492177
Review URL: https://codereview.chromium.org/1153143004
Cr-Commit-Position: refs/heads/master@{#331474}
Diffstat (limited to 'components/gcm_driver/gcm_client_impl_unittest.cc')
0 files changed, 0 insertions, 0 deletions