diff options
author | brettw <brettw@chromium.org> | 2016-02-02 16:51:43 -0800 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-02-03 00:52:49 +0000 |
commit | 1f5feb7e317e3c257090858e950273b64a2e31ef (patch) | |
tree | 9322f3ed006e3c0b0a383fc1439e61ba3674118d /components/history | |
parent | e788ae26ee13d972ac0299bd121978cfc7185fb1 (diff) | |
download | chromium_src-1f5feb7e317e3c257090858e950273b64a2e31ef.zip chromium_src-1f5feb7e317e3c257090858e950273b64a2e31ef.tar.gz chromium_src-1f5feb7e317e3c257090858e950273b64a2e31ef.tar.bz2 |
Delete base/prefs and update callers to use components.
Deletes the forwarding headers in base/prefs.
Updates the remaining users of base/prefs includes to use components/prefs.
Sort headers in updated files.
Move PrefServiceFactory out of the base namespace. Update users.
Update all preprocessor stuff in components/prefs to change BASE_PREFS_ to
COMPONENTS_PREFS_.
Add components/prefs to DEPS file of directories where checkdeps fails after
the update.
BUG=583034
Review URL: https://codereview.chromium.org/1662523004
Cr-Commit-Position: refs/heads/master@{#373105}
Diffstat (limited to 'components/history')
7 files changed, 11 insertions, 10 deletions
diff --git a/components/history/DEPS b/components/history/DEPS index 9111271..01352e6 100644 --- a/components/history/DEPS +++ b/components/history/DEPS @@ -2,6 +2,7 @@ include_rules = [ "+components/favicon_base", "+components/keyed_service", "+components/query_parser", + "+components/prefs", "+components/signin/core", "+components/sync_driver", "+google_apis/gaia", diff --git a/components/history/core/browser/expire_history_backend_unittest.cc b/components/history/core/browser/expire_history_backend_unittest.cc index 149a92e..feb4933 100644 --- a/components/history/core/browser/expire_history_backend_unittest.cc +++ b/components/history/core/browser/expire_history_backend_unittest.cc @@ -17,8 +17,6 @@ #include "base/macros.h" #include "base/memory/scoped_ptr.h" #include "base/message_loop/message_loop.h" -#include "base/prefs/pref_registry_simple.h" -#include "base/prefs/testing_pref_service.h" #include "base/scoped_observer.h" #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" @@ -35,6 +33,8 @@ #include "components/history/core/test/test_history_database.h" #include "components/history/core/test/thumbnail.h" #include "components/history/core/test/wait_top_sites_loaded_observer.h" +#include "components/prefs/pref_registry_simple.h" +#include "components/prefs/testing_pref_service.h" #include "testing/gtest/include/gtest/gtest.h" // The test must be in the history namespace for the gtest forward declarations diff --git a/components/history/core/browser/history_backend_unittest.cc b/components/history/core/browser/history_backend_unittest.cc index 13bcad8..a1574fb 100644 --- a/components/history/core/browser/history_backend_unittest.cc +++ b/components/history/core/browser/history_backend_unittest.cc @@ -24,7 +24,6 @@ #include "base/metrics/histogram_base.h" #include "base/metrics/histogram_samples.h" #include "base/metrics/statistics_recorder.h" -#include "base/prefs/pref_service.h" #include "base/run_loop.h" #include "base/strings/string16.h" #include "base/strings/string_number_conversions.h" @@ -46,6 +45,7 @@ #include "components/history/core/test/database_test_utils.h" #include "components/history/core/test/history_client_fake_bookmarks.h" #include "components/history/core/test/test_history_database.h" +#include "components/prefs/pref_service.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/skia/include/core/SkBitmap.h" diff --git a/components/history/core/browser/top_sites_impl.cc b/components/history/core/browser/top_sites_impl.cc index 09458bf..fb8e080 100644 --- a/components/history/core/browser/top_sites_impl.cc +++ b/components/history/core/browser/top_sites_impl.cc @@ -16,9 +16,6 @@ #include "base/md5.h" #include "base/memory/ref_counted_memory.h" #include "base/metrics/histogram_macros.h" -#include "base/prefs/pref_registry_simple.h" -#include "base/prefs/pref_service.h" -#include "base/prefs/scoped_user_pref_update.h" #include "base/single_thread_task_runner.h" #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" @@ -34,6 +31,9 @@ #include "components/history/core/browser/top_sites_observer.h" #include "components/history/core/browser/url_utils.h" #include "components/history/core/common/thumbnail_score.h" +#include "components/prefs/pref_registry_simple.h" +#include "components/prefs/pref_service.h" +#include "components/prefs/scoped_user_pref_update.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/layout.h" #include "ui/base/resource/resource_bundle.h" diff --git a/components/history/core/browser/top_sites_impl_unittest.cc b/components/history/core/browser/top_sites_impl_unittest.cc index 2efb4af..a36357d 100644 --- a/components/history/core/browser/top_sites_impl_unittest.cc +++ b/components/history/core/browser/top_sites_impl_unittest.cc @@ -12,8 +12,6 @@ #include "base/macros.h" #include "base/memory/weak_ptr.h" #include "base/message_loop/message_loop.h" -#include "base/prefs/pref_registry_simple.h" -#include "base/prefs/testing_pref_service.h" #include "base/strings/utf_string_conversions.h" #include "base/task/cancelable_task_tracker.h" #include "build/build_config.h" @@ -29,6 +27,8 @@ #include "components/history/core/test/history_unittest_base.h" #include "components/history/core/test/test_history_database.h" #include "components/history/core/test/wait_top_sites_loaded_observer.h" +#include "components/prefs/pref_registry_simple.h" +#include "components/prefs/testing_pref_service.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/skia/include/core/SkBitmap.h" #include "url/gurl.h" diff --git a/components/history/core/browser/typed_url_data_type_controller.cc b/components/history/core/browser/typed_url_data_type_controller.cc index 462569f..d833f02 100644 --- a/components/history/core/browser/typed_url_data_type_controller.cc +++ b/components/history/core/browser/typed_url_data_type_controller.cc @@ -7,9 +7,9 @@ #include "base/bind.h" #include "base/callback.h" #include "base/metrics/histogram.h" -#include "base/prefs/pref_service.h" #include "components/history/core/browser/history_db_task.h" #include "components/history/core/browser/history_service.h" +#include "components/prefs/pref_service.h" #include "components/sync_driver/sync_client.h" namespace browser_sync { diff --git a/components/history/core/browser/typed_url_data_type_controller.h b/components/history/core/browser/typed_url_data_type_controller.h index 58c4e8d..9e84a35 100644 --- a/components/history/core/browser/typed_url_data_type_controller.h +++ b/components/history/core/browser/typed_url_data_type_controller.h @@ -10,8 +10,8 @@ #include "base/compiler_specific.h" #include "base/macros.h" #include "base/memory/ref_counted.h" -#include "base/prefs/pref_change_registrar.h" #include "base/task/cancelable_task_tracker.h" +#include "components/prefs/pref_change_registrar.h" #include "components/sync_driver/non_ui_data_type_controller.h" #include "components/sync_driver/sync_api_component_factory.h" |