summaryrefslogtreecommitdiffstats
path: root/components/html_viewer/html_frame_tree_manager.cc
diff options
context:
space:
mode:
authorsky <sky@chromium.org>2015-07-24 10:42:12 -0700
committerCommit bot <commit-bot@chromium.org>2015-07-24 17:42:44 +0000
commite818c5dc18f87a93efd2992faf2edce3af840129 (patch)
tree5d85be67ea4b67e497aafbb742baebc2fcef0b72 /components/html_viewer/html_frame_tree_manager.cc
parent9b3b8adb3c2ed5df2f6ce782e67714e0abe0aaf4 (diff)
downloadchromium_src-e818c5dc18f87a93efd2992faf2edce3af840129.zip
chromium_src-e818c5dc18f87a93efd2992faf2edce3af840129.tar.gz
chromium_src-e818c5dc18f87a93efd2992faf2edce3af840129.tar.bz2
Adds NavigatorHost functions on Frame
There is no point in having this on a separate interface when it is tied with the frame api. When we nuke the non-OOPIFs path we can ditch NavigatorHost. BUG=479172,490221 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/1249413002 Cr-Commit-Position: refs/heads/master@{#340289}
Diffstat (limited to 'components/html_viewer/html_frame_tree_manager.cc')
-rw-r--r--components/html_viewer/html_frame_tree_manager.cc24
1 files changed, 9 insertions, 15 deletions
diff --git a/components/html_viewer/html_frame_tree_manager.cc b/components/html_viewer/html_frame_tree_manager.cc
index 3f1f1e0..cea0023 100644
--- a/components/html_viewer/html_frame_tree_manager.cc
+++ b/components/html_viewer/html_frame_tree_manager.cc
@@ -26,18 +26,18 @@
namespace html_viewer {
namespace {
-mojo::Target WebNavigationPolicyToNavigationTarget(
+mandoline::NavigationTarget WebNavigationPolicyToNavigationTarget(
blink::WebNavigationPolicy policy) {
switch (policy) {
case blink::WebNavigationPolicyCurrentTab:
- return mojo::TARGET_SOURCE_NODE;
+ return mandoline::NAVIGATION_TARGET_SOURCE_NODE;
case blink::WebNavigationPolicyNewBackgroundTab:
case blink::WebNavigationPolicyNewForegroundTab:
case blink::WebNavigationPolicyNewWindow:
case blink::WebNavigationPolicyNewPopup:
- return mojo::TARGET_NEW_NODE;
+ return mandoline::NAVIGATION_TARGET_NEW_NODE;
default:
- return mojo::TARGET_DEFAULT;
+ return mandoline::NAVIGATION_TARGET_DEFAULT;
}
}
@@ -99,7 +99,6 @@ HTMLFrameTreeManager::HTMLFrameTreeManager(
delegate_(nullptr),
local_frame_id_(local_frame_id),
server_(server.Pass()),
- navigator_host_(app_connection->GetServiceProvider()),
root_(nullptr) {}
HTMLFrameTreeManager::~HTMLFrameTreeManager() {
@@ -140,14 +139,10 @@ blink::WebNavigationPolicy HTMLFrameTreeManager::DecidePolicyForNavigation(
if (CanNavigateLocally(info.frame, info.urlRequest))
return info.defaultPolicy;
- // TODO(sky): this is wrong for subframes. In fact NavigatorHost should likely
- // be merged with Frame.
- if (navigator_host_.get()) {
- mojo::URLRequestPtr url_request = mojo::URLRequest::From(info.urlRequest);
- navigator_host_->RequestNavigate(
- WebNavigationPolicyToNavigationTarget(info.defaultPolicy),
- url_request.Pass());
- }
+ mojo::URLRequestPtr url_request = mojo::URLRequest::From(info.urlRequest);
+ server_->RequestNavigate(
+ frame->id(), WebNavigationPolicyToNavigationTarget(info.defaultPolicy),
+ url_request.Pass());
return blink::WebNavigationPolicyIgnore;
}
@@ -159,8 +154,7 @@ void HTMLFrameTreeManager::OnFrameDidFinishLoad(HTMLFrame* frame) {
void HTMLFrameTreeManager::OnFrameDidNavigateLocally(HTMLFrame* frame,
const std::string& url) {
- if (navigator_host_.get() && frame == root_)
- navigator_host_->DidNavigateLocally(url);
+ server_->DidNavigateLocally(frame->id(), url);
}
void HTMLFrameTreeManager::OnFrameDestroyed(HTMLFrame* frame) {