diff options
| author | pkasting <pkasting@chromium.org> | 2014-12-11 19:34:22 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-12 03:34:40 +0000 |
| commit | 07622896891ccc5e8279be55bae52c6323f025ff (patch) | |
| tree | d14263e37c072929a54b8523d317fbe0771cb9a2 /components/infobars.gypi | |
| parent | 41ec9ff4ad115e94ed3e9b2d96c42e5f6eb07f2c (diff) | |
| download | chromium_src-07622896891ccc5e8279be55bae52c6323f025ff.zip chromium_src-07622896891ccc5e8279be55bae52c6323f025ff.tar.gz chromium_src-07622896891ccc5e8279be55bae52c6323f025ff.tar.bz2 | |
Move infobar constants and the code that uses them from components/ to chrome/.
Both the infobar and the infobar container were making use of various infobar
constants that were declared in components/ but (usually) defined in chrome/.
This was a symptom of having put code in the component that really probably
belonged in the embedder.
This CL hoists the relevant logic to a new cross-platform
InfoBarContainerDelegate class defined on the chrome side, which implements some
of the methods of InfoBarContainer::Delegate. Platforms then subclass this to
implement the remaining, platform-specific bits.
This means that the constants in question now live solely in chrome/, avoiding a
bunch of link-time nastiness when trying to build the components code
separately.
BUG=382924
TEST=none
TBR=finnur
Review URL: https://codereview.chromium.org/793783003
Cr-Commit-Position: refs/heads/master@{#308046}
Diffstat (limited to 'components/infobars.gypi')
| -rw-r--r-- | components/infobars.gypi | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/components/infobars.gypi b/components/infobars.gypi index 172a7b6..ad13b70 100644 --- a/components/infobars.gypi +++ b/components/infobars.gypi @@ -27,7 +27,6 @@ 'infobars/core/confirm_infobar_delegate.h', 'infobars/core/infobar.cc', 'infobars/core/infobar.h', - 'infobars/core/infobar_android.cc', 'infobars/core/infobar_container.cc', 'infobars/core/infobar_container.h', 'infobars/core/infobar_delegate.cc', |