summaryrefslogtreecommitdiffstats
path: root/components/json_schema/json_schema_validator.cc
diff options
context:
space:
mode:
authorkinaba@chromium.org <kinaba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-31 06:38:29 +0000
committerkinaba@chromium.org <kinaba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-10-31 06:38:29 +0000
commite685143bd7d15b048b7ca9cb4ec0240827842266 (patch)
tree74f100269c45c656a554a794d4e63749b91fe026 /components/json_schema/json_schema_validator.cc
parent7a29680b81b983ac1da1b5fdbe3ad096bad7015a (diff)
downloadchromium_src-e685143bd7d15b048b7ca9cb4ec0240827842266.zip
chromium_src-e685143bd7d15b048b7ca9cb4ec0240827842266.tar.gz
chromium_src-e685143bd7d15b048b7ca9cb4ec0240827842266.tar.bz2
Revert 231982 "Docserver: Display enum value descriptions in API..."
"JsonSchemaTest.TestEnum" started failing on Windows bot after this change. > Docserver: Display enum value descriptions in API docs. > > This modifies the json schema to allow both primitive types and > dictionaries with properties "name" and optional "description" for enum > values. > > BUG=310454 > > Review URL: https://codereview.chromium.org/39113003 TBR=sammc@chromium.org Review URL: https://codereview.chromium.org/47403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232016 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/json_schema/json_schema_validator.cc')
-rw-r--r--components/json_schema/json_schema_validator.cc25
1 files changed, 0 insertions, 25 deletions
diff --git a/components/json_schema/json_schema_validator.cc b/components/json_schema/json_schema_validator.cc
index 3cc9e2b..3816a76 100644
--- a/components/json_schema/json_schema_validator.cc
+++ b/components/json_schema/json_schema_validator.cc
@@ -53,18 +53,6 @@ bool CompareToString(const ExpectedType& entry, const std::string& key) {
return entry.key < key;
}
-// If |value| is a dictionary, returns the "name" attribute of |value| or NULL
-// if |value| does not contain a "name" attribute. Otherwise, returns |value|.
-const base::Value* ExtractNameFromDictionary(const base::Value* value) {
- const base::DictionaryValue* value_dict = NULL;
- const base::Value* name_value = NULL;
- if (value->GetAsDictionary(&value_dict)) {
- value_dict->Get("name", &name_value);
- return name_value;
- }
- return value;
-}
-
bool IsValidSchema(const base::DictionaryValue* dict, std::string* error) {
// This array must be sorted, so that std::lower_bound can perform a
// binary search.
@@ -207,13 +195,6 @@ bool IsValidSchema(const base::DictionaryValue* dict, std::string* error) {
for (size_t i = 0; i < list_value->GetSize(); ++i) {
const base::Value* value = NULL;
list_value->Get(i, &value);
- // Sometimes the enum declaration is a dictionary with the enum value
- // under "name".
- value = ExtractNameFromDictionary(value);
- if (!value) {
- *error = "Invalid value in enum attribute";
- return false;
- }
switch (value->GetType()) {
case base::Value::TYPE_NULL:
case base::Value::TYPE_BOOLEAN:
@@ -498,12 +479,6 @@ void JSONSchemaValidator::ValidateEnum(const base::Value* instance,
for (size_t i = 0; i < choices->GetSize(); ++i) {
const base::Value* choice = NULL;
CHECK(choices->Get(i, &choice));
- // Sometimes the enum declaration is a dictionary with the enum value under
- // "name".
- choice = ExtractNameFromDictionary(choice);
- if (!choice) {
- NOTREACHED();
- }
switch (choice->GetType()) {
case base::Value::TYPE_NULL:
case base::Value::TYPE_BOOLEAN: