diff options
| author | mpearson@chromium.org <mpearson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-08 00:02:22 +0000 |
|---|---|---|
| committer | mpearson@chromium.org <mpearson@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-08 00:02:22 +0000 |
| commit | 3dc75b1cccf30ccce1f13553353c21c21d6a3e34 (patch) | |
| tree | 2ae602d45cb7006f3dffe30cc8c9d43038b0b5df /components/metrics.gypi | |
| parent | 702484bde5a044d224230f08ea12aeeb7cd069d6 (diff) | |
| download | chromium_src-3dc75b1cccf30ccce1f13553353c21c21d6a3e34.zip chromium_src-3dc75b1cccf30ccce1f13553353c21c21d6a3e34.tar.gz chromium_src-3dc75b1cccf30ccce1f13553353c21c21d6a3e34.tar.bz2 | |
Omnibox: Combine Two Input Type Enums into One
There are two input type enums:
* one in the autocomplete code
* one in the metrics code that's used for UMA logging;
this one is meant to remain stable
As part of fixing the linked bug, I created
https://codereview.chromium.org/314773002/
whch needed an input type enum, one which would remain stable.
It didn't necessarily have to be the metrics enum.
After discussion with the UMA folks (who deal with how to handle
stable enum problems all the time), we reached the conclusion
that we should have one stable enum and use it everywhere. That's
the cleanest answer.
This single enum has to live in the metrics directory because metrics
is a component.
This change combines the two existing enums into one, putting the
new enum in a new file in the metrics directory. The reason for
a new file is so we can include it without include the whole
OmniboxEventProto or any other metrics code.
The main files to review are autocomplete_input.h and *.proto.
All other changes are a mechanical result of the changes in
those three files.
The internal proto change has been submitted.
TBR=stevenjb
for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
that removes an unnecessary include
BUG=284781
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275696
Review URL: https://codereview.chromium.org/319523005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275713 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/metrics.gypi')
| -rw-r--r-- | components/metrics.gypi | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/components/metrics.gypi b/components/metrics.gypi index b9d4420..0a48dac 100644 --- a/components/metrics.gypi +++ b/components/metrics.gypi @@ -83,6 +83,7 @@ 'metrics/proto/chrome_user_metrics_extension.proto', 'metrics/proto/histogram_event.proto', 'metrics/proto/omnibox_event.proto', + 'metrics/proto/omnibox_input_type.proto', 'metrics/proto/perf_data.proto', 'metrics/proto/profiler_event.proto', 'metrics/proto/sampled_profile.proto', |