summaryrefslogtreecommitdiffstats
path: root/components/metrics.gypi
diff options
context:
space:
mode:
authorsungmann.cho@navercorp.com <sungmann.cho@navercorp.com@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-13 13:09:14 +0000
committersungmann.cho@navercorp.com <sungmann.cho@navercorp.com@0039d316-1c4b-4281-b951-d872f2087c98>2014-06-13 13:09:14 +0000
commita2d6ed8e40f2747490558f311c438fa0245d262a (patch)
tree2b83da4ece218616a1a15254e3a60895f256a0e5 /components/metrics.gypi
parenta1532cdbcc46d83cd46c445511fa49477a463e22 (diff)
downloadchromium_src-a2d6ed8e40f2747490558f311c438fa0245d262a.zip
chromium_src-a2d6ed8e40f2747490558f311c438fa0245d262a.tar.gz
chromium_src-a2d6ed8e40f2747490558f311c438fa0245d262a.tar.bz2
Fix a crash when clicking "Distill page" menu item.
Currently, Chrome Shell for Android crashes when we click the "Distill page" menu item(see the below logs for details). Actually, this is due to the fact described in https://codereview.chromium.org/333823004, but it seems there is a possibility that the given tab view is not equal to |mCurrentView|. So we need to update |mCurrentView| when TabObserver.onContentChanged() is called. java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first. at android.view.ViewGroup.addViewInner(ViewGroup.java:3562) at android.view.ViewGroup.addView(ViewGroup.java:3415) at android.view.ViewGroup.addView(ViewGroup.java:3360) at android.view.ViewGroup.addView(ViewGroup.java:3336) at org.chromium.chrome.shell.TabManager.setupContent(TabManager.java:148) at org.chromium.chrome.shell.TabManager.access$500(TabManager.java:27) at org.chromium.chrome.shell.TabManager$3.onContentChanged(TabManager.java:137) at org.chromium.chrome.browser.Tab.swapContentViewCore(Tab.java:1071) at org.chromium.chrome.browser.Tab.swapWebContents(Tab.java:1034) at org.chromium.chrome.browser.dom_distiller.DomDistillerTabUtils.nativeDistillCurrentPageAndView(Native Method) at org.chromium.chrome.browser.dom_distiller.DomDistillerTabUtils.distillCurrentPageAndView(DomDistillerTabUtils.java:27) at org.chromium.chrome.shell.ChromeShellActivity.onOptionsItemSelected(ChromeShellActivity.java:309) at org.chromium.chrome.browser.appmenu.AppMenuHandler.onOptionsItemSelected(AppMenuHandler.java:150) at org.chromium.chrome.browser.appmenu.AppMenu.onItemClick(AppMenu.java:177) at org.chromium.chrome.browser.appmenu.AppMenuAdapter$1.onClick(AppMenuAdapter.java:114) at android.view.View.performClick(View.java:4438) at android.view.View$PerformClick.run(View.java:18422) at android.os.Handler.handleCallback(Handler.java:733) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5001) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601) at dalvik.system.NativeStart.main(Native Method) BUG=none Review URL: https://codereview.chromium.org/336433006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277008 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/metrics.gypi')
0 files changed, 0 insertions, 0 deletions