diff options
| author | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-07 23:19:13 +0000 |
|---|---|---|
| committer | dcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-06-07 23:19:13 +0000 |
| commit | abd026a3eac873378b52adbe9ec630536ad449c3 (patch) | |
| tree | 8133682557af9ff57c6c1ca110ec1a028ccf540d /components/metrics.gypi | |
| parent | 776528535c8a8f079c6b805846e776695f46b9d2 (diff) | |
| download | chromium_src-abd026a3eac873378b52adbe9ec630536ad449c3.zip chromium_src-abd026a3eac873378b52adbe9ec630536ad449c3.tar.gz chromium_src-abd026a3eac873378b52adbe9ec630536ad449c3.tar.bz2 | |
Revert of Omnibox: Combine Two Input Type Enums into One (https://codereview.chromium.org/319523005/)
Reason for revert:
Broke the build on http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac
Original issue's description:
> Omnibox: Combine Two Input Type Enums into One
>
> There are two input type enums:
> * one in the autocomplete code
> * one in the metrics code that's used for UMA logging;
> this one is meant to remain stable
>
> As part of fixing the linked bug, I created
> https://codereview.chromium.org/314773002/
> whch needed an input type enum, one which would remain stable.
> It didn't necessarily have to be the metrics enum.
>
> After discussion with the UMA folks (who deal with how to handle
> stable enum problems all the time), we reached the conclusion
> that we should have one stable enum and use it everywhere. That's
> the cleanest answer.
>
> This single enum has to live in the metrics directory because metrics
> is a component.
>
> This change combines the two existing enums into one, putting the
> new enum in a new file in the metrics directory. The reason for
> a new file is so we can include it without include the whole
> OmniboxEventProto or any other metrics code.
>
> The main files to review are autocomplete_input.h and *.proto.
> All other changes are a mechanical result of the changes in
> those three files.
>
> The internal proto change has been submitted.
>
> TBR=stevenjb
> for the trivial change to chrome/browser/ui/app_list/search/omnibox_provider.cc
> that removes an unnecessary include
>
> BUG=284781
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275696
TBR=pkasting@chromium.org,isherman@chromium.org,mpearson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=284781
Review URL: https://codereview.chromium.org/320713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275706 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'components/metrics.gypi')
| -rw-r--r-- | components/metrics.gypi | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/components/metrics.gypi b/components/metrics.gypi index 0a48dac..b9d4420 100644 --- a/components/metrics.gypi +++ b/components/metrics.gypi @@ -83,7 +83,6 @@ 'metrics/proto/chrome_user_metrics_extension.proto', 'metrics/proto/histogram_event.proto', 'metrics/proto/omnibox_event.proto', - 'metrics/proto/omnibox_input_type.proto', 'metrics/proto/perf_data.proto', 'metrics/proto/profiler_event.proto', 'metrics/proto/sampled_profile.proto', |